Bug 1162709
| Summary: | The git-review script depends on the requests Python module, which is not reflected in the package dependency list | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gergely Polonkai <gergely> |
| Component: | git-review | Assignee: | Pete Zaitcev <zaitcev> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 21 | CC: | zaitcev |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | git-review-1.24-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-15 09:23:28 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
I clearly screwed it up, sorry. I actually even gave +1 to Cedric upstream, but I forgot about it. git-review-1.24-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/git-review-1.24-2.fc21 Package git-review-1.24-2.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing git-review-1.24-2.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-14979/git-review-1.24-2.fc21 then log in and leave karma (feedback). Works for me. I have added karma. git-review-1.24-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: git-review requires the requests Python module: $ git review Traceback (most recent call last): File "/usr/bin/git-review", line 6, in <module> from git_review.cmd import main File "/usr/lib/python2.7/site-packages/git_review/cmd.py", line 31, in <module> import requests ImportError: No module named requests Version-Release number of selected component (if applicable): 1.24-1.fc21 How reproducible: Install git-review while the requests module (python-requests package) is not present on your system; then run git-review. Actual results: Python traceback which complains about the requests module. Expected results: A working git-review tool. Additional info: The only problem here is that the git-review package doesn’t depend on the python-requests package. As soon as I install the latter, git-review works without a problem.