Bug 1162709 - The git-review script depends on the requests Python module, which is not reflected in the package dependency list
Summary: The git-review script depends on the requests Python module, which is not ref...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: git-review
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pete Zaitcev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-11 14:12 UTC by Gergely Polonkai
Modified: 2014-11-15 09:23 UTC (History)
1 user (show)

Fixed In Version: git-review-1.24-2.fc21
Clone Of:
Environment:
Last Closed: 2014-11-15 09:23:28 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Gergely Polonkai 2014-11-11 14:12:01 UTC
Description of problem:

git-review requires the requests Python module:

$ git review
Traceback (most recent call last):
  File "/usr/bin/git-review", line 6, in <module>
    from git_review.cmd import main
  File "/usr/lib/python2.7/site-packages/git_review/cmd.py", line 31, in <module>
    import requests
ImportError: No module named requests

Version-Release number of selected component (if applicable):

1.24-1.fc21

How reproducible:

Install git-review while the requests module (python-requests package) is not present on your system; then run git-review.

Actual results:

Python traceback which complains about the requests module.

Expected results:

A working git-review tool.

Additional info:

The only problem here is that the git-review package doesn’t depend on the python-requests package. As soon as I install the latter, git-review works without a problem.

Comment 1 Pete Zaitcev 2014-11-11 21:08:30 UTC
I clearly screwed it up, sorry. I actually even gave +1 to Cedric
upstream, but I forgot about it.

Comment 2 Fedora Update System 2014-11-12 01:07:14 UTC
git-review-1.24-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/git-review-1.24-2.fc21

Comment 3 Fedora Update System 2014-11-13 18:21:38 UTC
Package git-review-1.24-2.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing git-review-1.24-2.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-14979/git-review-1.24-2.fc21
then log in and leave karma (feedback).

Comment 4 Gergely Polonkai 2014-11-14 12:12:07 UTC
Works for me. I have added karma.

Comment 5 Fedora Update System 2014-11-15 09:23:28 UTC
git-review-1.24-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.