Bug 1164170
| Summary: | Review Request: golang-github-vishvananda-netns - Simple network namespace handling for go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Chaloupka <jchaloup> |
| Component: | Package Review | Assignee: | Lokesh Mandvekar <lsm5> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lsm5, package-review |
| Target Milestone: | --- | Flags: | lsm5:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | golang-github-vishvananda-netns-0-0.1.gite14a2d4.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-03 01:05:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1164176, 1165688 | ||
|
Description
Jan Chaloupka
2014-11-14 09:05:22 UTC
Needs %files like so:
%files devel
%doc README.md LICENSE
%dir %{gopath}/src/%{provider}.%{provider_tld}/%{project}
%dir %{gopath}/src/%{import_path}
%{gopath}/src/%{import_path}/*.go
As from http://www.rpm.org/max-rpm/s1-rpm-inside-files-list.html, third paragraph: "if the %files list contains a path to a directory, RPM will automatically package every file in that directory, as well as every file in each subdirectory" In this case, it will take all files and dirs copied to %{buildroot}/%{gopath}/src/%{import_path}/. What files/dirs are taken is decided in the install section: cp -pav *.go %{buildroot}/%{gopath}/src/%{import_path}/ So at the end, it will take just *.go files. What do you think Lokesh? Is this one of the correct ways how to handle packaged files or should this be more refined? $ rpm -qpl /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-vishvananda-netns-devel-0-0.1.gite14a2d4.fc20.noarch.rpm
/usr/share/doc/golang-github-vishvananda-netns-devel
/usr/share/doc/golang-github-vishvananda-netns-devel/LICENSE
/usr/share/doc/golang-github-vishvananda-netns-devel/README.md
/usr/share/gocode/src/github.com/vishvananda
/usr/share/gocode/src/github.com/vishvananda/netns
/usr/share/gocode/src/github.com/vishvananda/netns/netns.go
/usr/share/gocode/src/github.com/vishvananda/netns/netns_linux.go
/usr/share/gocode/src/github.com/vishvananda/netns/netns_linux_386.go
/usr/share/gocode/src/github.com/vishvananda/netns/netns_linux_amd.go
/usr/share/gocode/src/github.com/vishvananda/netns/netns_linux_arm.go
/usr/share/gocode/src/github.com/vishvananda/netns/netns_test.go
/usr/share/gocode/src/github.com/vishvananda/netns/netns_unspecified.go
The package owns %{gopath}/src/%{import_path} directory as well.
aah yup, you're right. https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_section also mentions something similar. specfile looks good as per golang package guidelines. Package approved! New Package SCM Request ======================= Package Name: golang-github-vishvananda-netns Short Description: Simple network namespace handling for go Upstream URL: https://github.com/vishvananda/netns Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig Git done (by process-git-requests). golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc20 golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc21 golang-github-vishvananda-netns-0-0.1.gite14a2d4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netns-0-0.1.gite14a2d4.el6 golang-github-vishvananda-netns-0-0.1.gite14a2d4.el6 has been pushed to the Fedora EPEL 6 testing repository. golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc20 has been pushed to the Fedora 20 stable repository. golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc21 has been pushed to the Fedora 21 stable repository. golang-github-vishvananda-netns-0-0.1.gite14a2d4.el6 has been pushed to the Fedora EPEL 6 stable repository. |