Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-vishvananda-netns/golang-github-vishvananda-netns.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-vishvananda-netns/golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc20.src.rpm Description: Simple network namespace handling for go Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8139703 $ rpmlint golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc20.src.rpm golang-github-vishvananda-netns-devel-0-0.1.gite14a2d4.fc20.noarch.rpm golang-github-vishvananda-netns.spec golang-github-vishvananda-netns.src: W: spelling-error Summary(en_US) namespace -> name space, name-space, names pace golang-github-vishvananda-netns.src: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace golang-github-vishvananda-netns-devel.noarch: W: spelling-error Summary(en_US) namespace -> name space, name-space, names pace golang-github-vishvananda-netns-devel.noarch: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Upstream URL: https://github.com/vishvananda/netns
Needs %files like so: %files devel %doc README.md LICENSE %dir %{gopath}/src/%{provider}.%{provider_tld}/%{project} %dir %{gopath}/src/%{import_path} %{gopath}/src/%{import_path}/*.go
As from http://www.rpm.org/max-rpm/s1-rpm-inside-files-list.html, third paragraph: "if the %files list contains a path to a directory, RPM will automatically package every file in that directory, as well as every file in each subdirectory" In this case, it will take all files and dirs copied to %{buildroot}/%{gopath}/src/%{import_path}/. What files/dirs are taken is decided in the install section: cp -pav *.go %{buildroot}/%{gopath}/src/%{import_path}/ So at the end, it will take just *.go files. What do you think Lokesh? Is this one of the correct ways how to handle packaged files or should this be more refined?
$ rpm -qpl /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-vishvananda-netns-devel-0-0.1.gite14a2d4.fc20.noarch.rpm /usr/share/doc/golang-github-vishvananda-netns-devel /usr/share/doc/golang-github-vishvananda-netns-devel/LICENSE /usr/share/doc/golang-github-vishvananda-netns-devel/README.md /usr/share/gocode/src/github.com/vishvananda /usr/share/gocode/src/github.com/vishvananda/netns /usr/share/gocode/src/github.com/vishvananda/netns/netns.go /usr/share/gocode/src/github.com/vishvananda/netns/netns_linux.go /usr/share/gocode/src/github.com/vishvananda/netns/netns_linux_386.go /usr/share/gocode/src/github.com/vishvananda/netns/netns_linux_amd.go /usr/share/gocode/src/github.com/vishvananda/netns/netns_linux_arm.go /usr/share/gocode/src/github.com/vishvananda/netns/netns_test.go /usr/share/gocode/src/github.com/vishvananda/netns/netns_unspecified.go The package owns %{gopath}/src/%{import_path} directory as well.
aah yup, you're right. https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_section also mentions something similar. specfile looks good as per golang package guidelines. Package approved!
New Package SCM Request ======================= Package Name: golang-github-vishvananda-netns Short Description: Simple network namespace handling for go Upstream URL: https://github.com/vishvananda/netns Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig
Git done (by process-git-requests).
golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc20
golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc21
golang-github-vishvananda-netns-0-0.1.gite14a2d4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netns-0-0.1.gite14a2d4.el6
golang-github-vishvananda-netns-0-0.1.gite14a2d4.el6 has been pushed to the Fedora EPEL 6 testing repository.
golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc20 has been pushed to the Fedora 20 stable repository.
golang-github-vishvananda-netns-0-0.1.gite14a2d4.fc21 has been pushed to the Fedora 21 stable repository.
golang-github-vishvananda-netns-0-0.1.gite14a2d4.el6 has been pushed to the Fedora EPEL 6 stable repository.