Bug 1164176

Summary: Review Request: golang-github-vishvananda-netlink - Simple netlink library for go
Product: [Fedora] Fedora Reporter: Jan Chaloupka <jchaloup>
Component: Package ReviewAssignee: Lokesh Mandvekar <lsm5>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: lsm5, package-review
Target Milestone: ---Flags: lsm5: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: golang-github-vishvananda-netlink-0-0.2.git991a7a2.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-03 01:02:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1164170    
Bug Blocks: 1165688    

Description Jan Chaloupka 2014-11-14 09:21:23 UTC 
Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-vishvananda-netlink/golang-github-vishvananda-netlink.spec

SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-vishvananda-netlink/golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc20.src.rpm

Description: The netlink package provides a simple netlink library for go.
Netlink is the interface a user-space program in linux uses to communicate
with the kernel. It can be used to add and remove interfaces, set ip addresses
and routes, and configure ipsec. Netlink communication requires elevated
privileges, so in most cases this code needs to be run as root. Since low-level
netlink messages are inscrutable at best, the library attempts to provide
an api that is loosely modeled on the CLI provied by iproute2.
Actions like ip link add will be accomplished via a similarly named function
like AddLink(). This library began its life as a fork of the netlink
functionality in docker/libcontainer but was heavily rewritten to improve
testability,performance, and to add new functionality like ipsec xfrm handling.

Fedora Account System Username: jchaloup

Koji: Depends on golang-github-vishvananda-netns, which is not in Fedora yet. Review https://bugzilla.redhat.com/show_bug.cgi?id=1164170. Locally building succesfully.

$ rpmlint golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc20.src.rpm golang-github-vishvananda-netlink-devel-0-0.1.git2187ba6.fc20.noarch.rpm golang-github-vishvananda-netlink.spec
golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US linux -> Linux
golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US ip -> pi, up, op
golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US ipsec -> eclipse
golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US api -> pi, ape, apt
golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US provied -> provide, proved, provided
golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US libcontainer -> lib container, lib-container, containerize
golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US testability -> test ability, test-ability, incontestability
golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US xfrm -> farm
2 packages and 1 specfiles checked; 0 errors, 8 warnings.

Upstream URL: https://github.com/vishvananda/netlink
Comment 1 Lokesh Mandvekar 2014-11-19 19:05:19 UTC 
Change %files as in Bug 1164170

rest looks good
Comment 2 Lokesh Mandvekar 2014-11-20 15:45:02 UTC 
%files looks good in original spec. Package approved! specfile conforms to golang packaging guidelines.
Comment 3 Jan Chaloupka 2014-11-20 16:08:43 UTC 
New Package SCM Request
=======================
Package Name: golang-github-vishvananda-netlink
Short Description: Simple netlink library for go
Upstream URL: https://github.com/vishvananda/netlink
Owners: jchaloup lsm5 vbatts
Branches: f21 f20 f19 el6
InitialCC: golang-sig
Comment 4 Gwyn Ciesla 2014-11-20 16:22:53 UTC 
Git done (by process-git-requests).
Comment 5 Fedora Update System 2014-11-21 11:19:29 UTC 
golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc20
Comment 6 Fedora Update System 2014-11-21 11:19:45 UTC 
golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc21
Comment 7 Fedora Update System 2014-11-21 11:20:03 UTC 
golang-github-vishvananda-netlink-0-0.1.git2187ba6.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-0.1.git2187ba6.el6
Comment 8 Fedora Update System 2014-11-22 04:15:40 UTC 
golang-github-vishvananda-netlink-0-0.1.git2187ba6.el6 has been pushed to the Fedora EPEL 6 testing repository.
Comment 9 Fedora Update System 2014-12-03 01:02:41 UTC 
golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc20 has been pushed to the Fedora 20 stable repository.
Comment 10 Fedora Update System 2014-12-06 10:05:44 UTC 
golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc21 has been pushed to the Fedora 21 stable repository.
Comment 11 Fedora Update System 2014-12-06 17:07:32 UTC 
golang-github-vishvananda-netlink-0-0.1.git2187ba6.el6 has been pushed to the Fedora EPEL 6 stable repository.
Comment 12 Fedora Update System 2015-05-20 16:39:11 UTC 
golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc22
Comment 13 Fedora Update System 2015-05-20 16:39:28 UTC 
golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc21
Comment 14 Fedora Update System 2015-05-20 16:39:44 UTC 
golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc20
Comment 15 Fedora Update System 2015-05-20 16:39:59 UTC 
golang-github-vishvananda-netlink-0-0.2.git991a7a2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-0.2.git991a7a2.el6
Comment 16 Fedora Update System 2015-05-30 15:45:15 UTC 
golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 17 Fedora Update System 2015-05-30 15:49:06 UTC 
golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 18 Fedora Update System 2015-05-30 15:55:42 UTC 
golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 19 Fedora Update System 2015-06-04 15:56:34 UTC 
golang-github-vishvananda-netlink-0-0.2.git991a7a2.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.