Bug 1164600

Summary: [GSS] (6.4.0) ServletContainerInitializerDeploymentProcessor does not handle comments
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: James Livingston <jlivings>
Component: WebAssignee: Rémy Maucherat <rmaucher>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Cada <mcada>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.3.2CC: joallen, pjindal
Target Milestone: DR11   
Target Release: EAP 6.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1165967 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1165967    

Description James Livingston 2014-11-16 23:34:15 UTC 
ServletContainerInitializerDeploymentProcessor.loadSci() has code to read the service file, rather than using the JDK-provided mechanisms, and it does not handle comments.

The API documentation at https://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html says that the # symbols and all following characters on the line should be ignored. It also notes the file must be UTF-8 encoded, and ServletContainerInitializerDeploymentProcessor does not appear to force that either.


Log4j 2.1 triggers this bug (https://issues.apache.org/jira/browse/LOG4J2-890). Although WFLY-4089 is about the Undertow subsystem, that DUP is basically the same between it and the old web subsystem, so the same change should apply apart from the package/path name change.
Comment 2 Rémy Maucherat 2014-11-18 11:51:19 UTC 
The PR is not merged, so it is still NEW.
Comment 4 Radim Hatlapatka 2014-12-01 12:59:00 UTC 
Verified in EAP 6.4.0.DR11