Bug 1164600 - [GSS] (6.4.0) ServletContainerInitializerDeploymentProcessor does not handle comments
Summary: [GSS] (6.4.0) ServletContainerInitializerDeploymentProcessor does not handle ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Web
Version: 6.3.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: DR11
: EAP 6.4.0
Assignee: Rémy Maucherat
QA Contact: Michael Cada
URL:
Whiteboard:
Depends On:
Blocks: 1165967
TreeView+ depends on / blocked
 
Reported: 2014-11-16 23:34 UTC by James Livingston
Modified: 2019-08-19 12:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
: 1165967 (view as bug list)
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker WFLY-4089 0 Major Closed ServletContainerInitializerDeploymentProcessor does not handle comments 2018-08-09 09:46:03 UTC

Description James Livingston 2014-11-16 23:34:15 UTC
ServletContainerInitializerDeploymentProcessor.loadSci() has code to read the service file, rather than using the JDK-provided mechanisms, and it does not handle comments.

The API documentation at https://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html says that the # symbols and all following characters on the line should be ignored. It also notes the file must be UTF-8 encoded, and ServletContainerInitializerDeploymentProcessor does not appear to force that either.


Log4j 2.1 triggers this bug (https://issues.apache.org/jira/browse/LOG4J2-890). Although WFLY-4089 is about the Undertow subsystem, that DUP is basically the same between it and the old web subsystem, so the same change should apply apart from the package/path name change.

Comment 2 Rémy Maucherat 2014-11-18 11:51:19 UTC
The PR is not merged, so it is still NEW.

Comment 4 Radim Hatlapatka 2014-12-01 12:59:00 UTC
Verified in EAP 6.4.0.DR11


Note You need to log in before you can comment on or make changes to this bug.