Bug 1165468

Summary: [abrt] git-review: cmd.py:31:<module>:ImportError: No module named requests
Product: [Fedora] Fedora Reporter: Jeff Morriss <jeff.morriss>
Component: git-reviewAssignee: Pete Zaitcev <zaitcev>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: jeff.morriss, zaitcev
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/280a5d91b095ea6ddf4db6b8ccd616fbb1d4d6a2
Whiteboard: abrt_hash:aa18420e09e625351dffc7ebc78f34d15cca7d42
Fixed In Version: git-review-1.24-2.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-01 18:58:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace
none
File: environ none

Description Jeff Morriss 2014-11-19 02:35:32 UTC
Description of problem:
Upgraded git review
Used git review to attempt to download a patch (git review -d XXXX)
Got the error:

Traceback (most recent call last):
  File "/usr/bin/git-review", line 6, in <module>
    from git_review.cmd import main
  File "/usr/lib/python2.7/site-packages/git_review/cmd.py", line 31, in <module>
    import requests
ImportError: No module named requests

Version-Release number of selected component:
git-review-1.24-1.fc19

Additional info:
reporter:       libreport-2.2.2
cmdline:        /usr/bin/python /usr/bin/git-review -d 5361
executable:     /usr/bin/git-review
kernel:         3.14.23-100.fc19.x86_64
runlevel:       N 5
type:           Python
uid:            500

Truncated backtrace:
#1 <module> in /usr/lib/python2.7/site-packages/git_review/cmd.py:31
#2 <module> in /usr/bin/git-review:6

Comment 1 Jeff Morriss 2014-11-19 02:35:34 UTC
Created attachment 958843 [details]
File: backtrace

Comment 2 Jeff Morriss 2014-11-19 02:35:35 UTC
Created attachment 958844 [details]
File: environ

Comment 3 Jeff Morriss 2014-11-19 02:39:49 UTC
It looks like installing "python-requests" is required.  Should be a dependency, of course.

Comment 4 Pete Zaitcev 2014-11-19 03:43:24 UTC
See also bug 1162709 (for F21).

Comment 5 Fedora Update System 2014-11-19 04:31:29 UTC
git-review-1.24-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/git-review-1.24-2.fc19

Comment 6 Pete Zaitcev 2014-11-19 04:33:03 UTC
Jeff, please test the build off the update link, thanks.

Comment 7 Fedora Update System 2014-11-19 15:57:51 UTC
Package git-review-1.24-2.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing git-review-1.24-2.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-15381/git-review-1.24-2.fc19
then log in and leave karma (feedback).

Comment 8 Jeff Morriss 2014-11-20 02:28:17 UTC
Yep, git-review-1.24-2.fc19 fixes it.

Steps to test:

0) yum remove git-review python-requests
1) yum install --enablerepo=updates-testing git-review-1.24-2.fc19

(1) also brought down the python-requests package as a dependency.  A quick check indicates git-review works.

Thanks for the quick turnaround!  (I don't have a admin.fedoraproject.org login in order to provide karma/feedback.)

Comment 9 Pete Zaitcev 2014-11-21 00:39:59 UTC
Sorry, but without a karma an update has to sit in updates-testing
for a week.

Comment 10 Fedora Update System 2014-12-01 18:58:20 UTC
git-review-1.24-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.