Bug 1165641

rpmlint is really unhappy with this one!

I guess the bundled btparse library should be packaged separately?

Ignore previous comment.

But I think I need some help with this one!  In particular, the unversioned shared lib "/usr/lib64/libbtparse.so"...

Here's my best effort so far:

http://people.maths.ox.ac.uk/macdonald/fedora/perl-Text-BibTeX-0.70-2.fc21.src.rpm

https://github.com/cbm755/fedora-spec/blob/master/perl-Text-BibTeX.spec

Since the btparse library is available as a standalone project, you should really package it separately, unbundle it and depend on the other btparse package.  You'll also have to patch Build.PL to use the external library.

I'll comment on the rest for now.

#1 btool_faw.pod seems to be useful.  Add it to %doc.

#2 Some BRs are missing.
From Build.PL and inc/MyBuilder.pm (loaded by Build.PL): perl(base), perl(Config), perl(ExtUtils::Mkbootstrap), perl(ExtUtils::ParseXS), perl(File::Copy), perl(File::Path), perl(File::Spec::Functions) and perl(lib).

#3 Tip: That shebang substitution could be done in one go, e.g. sed -ri 's#/usr/local/bin/perl5?#%{__perl}#' scripts/* examples/*; and similar for that chmod.

#4 About your first FIXME: Indeed, you should move this to a separate package, see above.

#5 About your second FIXME: These are also provided by btparse.  We probably want them but not here.

#6 About your third FIXME: `xscode' is a mapping between the perl code and the C library.  It creates the BibTeX.so file.  This is fine and you don't have to worry about it.

#7 After you unbundle the library, you won't need chrpath nor %{_mandir}/man1/*, %{_bindir}/* and %{_libdir}/*.so in you %files section.  This is probably obvious :)

Oops, I've just noticed the last release of the standalone btparse it really, really old.  And according to Text::BibTeX's changelog (v0.40_2, from 2010), it is now a part of this package.

So scratch what I said about unbundling in the previous comment -- keep it.  Keep the unversioned library too; upstream doesn't provide anything else.  We also want the installed binaries.

I'll take another look at this tomorrow.

#3: not so easy, its "perl5" and "perl".

Need man pages for the three utilities as per rpmlint?

A further iteration:

http://people.maths.ox.ac.uk/macdonald/fedora/perl-Text-BibTeX-0.70-3.fc21.src.rpm

https://raw.githubusercontent.com/cbm755/fedora-spec/master/perl-Text-BibTeX.spec

(In reply to Colin Macdonald from comment #5)
> #3: not so easy, its "perl5" and "perl".

That's why I call sed with `-r' and use `perl5?' in the expression :) That should work fine.

> Need man pages for the three utilities as per rpmlint?

Not unless you want to write them.

> A further iteration:
> 
> http://people.maths.ox.ac.uk/macdonald/fedora/perl-Text-BibTeX-0.70-3.fc21.
> src.rpm
> 
> https://raw.githubusercontent.com/cbm755/fedora-spec/master/perl-Text-BibTeX.
> spec

I dare to approve this now.  There isn't much you can do about that libbtparse.so (besides working with upstream and convincing them to version their ABI).

I see.  I'd rather concentrate on getting biber in for now.  Perhaps return to this issue later.

Is it complicated to put it in /usr/lib64/btparse/libbtparse.so or similar?  Docs refer to "rpath" for this...  But I readily admit I'm a bit over my head.

Oh, and I'll try your single-line sed before committing.

New Package SCM Request
=======================
Package Name: perl-Text-BibTeX
Short Description: Interface to read and parse BibTeX files
Upstream URL: http://search.cpan.org/dist/Text-BibTeX/
Owners: cbm mef
Branches: f21
InitialCC: perl-sig

New Package SCM Request
=======================
Package Name: perl-Text-BibTeX
Short Description: Interface to read and parse BibTeX files
Upstream URL: http://search.cpan.org/dist/Text-BibTeX/
Owners: cbm mef
Branches: f21
InitialCC: perl-sig

Git done (by process-git-requests).

(In reply to Colin Macdonald from comment #7)
> Is it complicated to put it in /usr/lib64/btparse/libbtparse.so or similar? 
> Docs refer to "rpath" for this...  But I readily admit I'm a bit over my
> head.

Judging by the docs, I think the library is meant to be used by other developers, if they wish to do so (despite the unversioned ABI).  For this reason, I would keep it in %{_libdir} (and delete rpath from the binaries).

If you think nobody but Text::BibTeX will ever use it, feel free to move it to a subdirectory (and utilize rpath in the binaries to find it; that is acceptable).  You will have to tinker with the package build system for this.

It can be done either way.  I prefer the first, option -- what we have now.

> I prefer the first, option -- what we have now.

Ok, thanks!

perl-Text-BibTeX-0.70-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Text-BibTeX-0.70-3.fc21

perl-Text-BibTeX-0.70-3.fc21 has been pushed to the Fedora 21 testing repository.

perl-Text-BibTeX-0.70-4.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Text-BibTeX-0.70-4.fc21

perl-Text-BibTeX-0.70-4.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.