Bug 1166232

Summary:	Libgfapi symbolic version breaking Samba Fedora rawhide (22) koji builds
Product:	[Community] GlusterFS	Reporter:	Lalatendu Mohanty <lmohanty>
Component:	libgfapi	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	mainline	CC:	bugs, gluster-bugs, ndevos
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1166293 (view as bug list)		Environment:
Last Closed:	2015-05-14 17:28:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1166293

Description Lalatendu Mohanty 2014-11-20 15:34:36 UTC

Description of problem:
The latest changes for libgfapi to keep  version of glusterfs-api.so to "0" is breaking Samba builds as Samba is looking for "glusterfs-api >= 4" in gluster-api.pc file. 

Refer http://koji.fedoraproject.org/koji/buildinfo?buildID=593897

Version-Release number of selected component (if applicable):

3.6.1 and later (that includes mainline) 

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

http://koji.fedoraproject.org/koji/buildinfo?buildID=593897

From: https://kojipkgs.fedoraproject.org//work/tasks/7114/8167114/build.log

hecking for glusterfs-api >= 4                                                                 : not found 
Checking for header api/glfs.h                                                                  : no 
Checking for library gfapi                                                                      : yes 
ERROR: Target 'gfapi' in directory /builddir/build/BUILD/samba-4.2.0rc2/source3 re-defined as EMPTY - was SYSLIB
error: Bad exit status from /var/tmp/rpm-tmp.j8Dm9x (%build)
    Macro %python_libdir defined but not used within scope
    Bad exit status from /var/tmp/rpm-tmp.j8Dm9x (%build)
RPM build errors:
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps  builddir/build/SPECS/samba.spec']
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 70, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 378, in do
    raise mockbuild.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps  builddir/build/SPECS/samba.spec']
LEAVE do --> EXCEPTION RAISED

Comment 1 Anand Avati 2014-11-20 15:42:55 UTC

REVIEW: http://review.gluster.org/9154 (pkg-config: make the version in gluster-api.pc backwards compatible) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Niels de Vos 2014-11-20 16:33:52 UTC

Build pushed to Fedora Rawhide:
- http://koji.fedoraproject.org/koji/buildinfo?buildID=594572

Comment 3 Anand Avati 2014-11-20 17:57:29 UTC

COMMIT: http://review.gluster.org/9154 committed in master by Niels de Vos (ndevos) 
------
commit 6ba258d2b7d4520af95ff638e02598e4aa247ec4
Author: Niels de Vos <ndevos>
Date:   Thu Nov 20 16:26:36 2014 +0100

    pkg-config: make the version in gluster-api.pc backwards compatible
    
    Once we released gluster-api.pc with version=4. Since then we undid the
    library versioning and replaced it with symbol-versioning. The current
    libgfapi.so has version 0, but the symbols have the version from the
    main package at the time they were added.
    
    Because other packages (like samba) use the pkg-config version, we can
    not drop it, or decrease the version easily. The simplest solution is to
    keep the version=4 and add sub-digits for the actual package/symbol
    versions. In future, the version in gluster-api.pc will be like 4.3.x.y.
    
    Change-Id: If359c8de5b847a7e818199a7246636113837da2d
    BUG: 1166232
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/9154
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Lalatendu Mohanty <lmohanty>
    Tested-by: Gluster Build System <jenkins.com>

Comment 4 Niels de Vos 2015-05-14 17:28:31 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:35:43 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:38:06 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:45:02 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user