Bug 1166421
| Summary: | Review Request: nodejs-sphericalmercator - Transformations between the Web Mercator projection and Latitude Longitude coordinates | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Eduardo Mayorga <e> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, piotr1212 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-03-28 20:36:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Eduardo Mayorga
2014-11-21 00:17:55 UTC
some comments: - Add: BuildRequires: nodejs-packaging, see: https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#BuildRequires rpmlint: - Check tab and space usage, retab to spaces, remove spaces at end of line - summary too long: E: summary-too-long C Transformations between the Web Mercator projection and Latitude Longitude coordinates - Add: %check section, see test in package.json for how to test. - Why is the > /dev/null in %install needed? Hi Eduardo, Latest version is now 1.0.3. You can also remove Group: this is only needed if you intend to package for EPEL5. I will do a full review if you upload a new version which solves all issues. Eduardo, Are you still interested in packaging this? I will close this bug if there is no response soon, according to: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews Spec URL: https://mayorga.fedorapeople.org/nodejs-sphericalmercator.spec SRPM URL: https://mayorga.fedorapeople.org/nodejs-sphericalmercator-1.0.3-1.fc20.src.rpm Excuse me for noticing this so late but it seems this package already is in Fedora, see: https://apps.fedoraproject.org/packages/nodejs-sphericalmercator *** This bug has been marked as a duplicate of bug 914937 *** |