Bug 1166421 - Review Request: nodejs-sphericalmercator - Transformations between the Web Mercator projection and Latitude Longitude coordinates
Summary: Review Request: nodejs-sphericalmercator - Transformations between the Web Me...
Keywords:
Status: CLOSED DUPLICATE of bug 914937
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-21 00:17 UTC by Eduardo Mayorga
Modified: 2015-03-28 20:36 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-03-28 20:36:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Eduardo Mayorga 2014-11-21 00:17:55 UTC
Spec URL: https://dl.dropboxusercontent.com/s/xg5dkzvqgtvkvfu/nodejs-sphericalmercator.spec
SRPM URL: https://dl.dropboxusercontent.com/s/ksebj2ifdec770g/nodejs-sphericalmercator-1.0.2-1.fc20.src.rpm
Description: Transformations between the Web Mercator projection and Latitude Longitude coordinates.
Fedora Account System Username: mayorga

Comment 1 Piotr Popieluch 2014-11-29 18:24:33 UTC
some comments:

- Add: BuildRequires: nodejs-packaging, see: https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#BuildRequires


rpmlint:
- Check tab and space usage, retab to spaces, remove spaces at end of line

- summary too long:
E: summary-too-long C Transformations between the Web Mercator projection and Latitude Longitude coordinates

- Add: %check section, see test in package.json for how to test.

- Why is the > /dev/null in %install needed?

Comment 2 Piotr Popieluch 2015-03-04 20:12:08 UTC
Hi Eduardo,

Latest version is now 1.0.3. You can also remove Group: this is only needed if you intend to package for EPEL5. I will do a full review if you upload a new version which solves all issues.

Comment 3 Piotr Popieluch 2015-03-20 23:18:19 UTC
Eduardo,

Are you still interested in packaging this? I will close this bug if there is no response soon, according to: 
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

Comment 5 Piotr Popieluch 2015-03-28 20:30:03 UTC
Excuse me for noticing this so late but it seems this package already is in Fedora, see:

https://apps.fedoraproject.org/packages/nodejs-sphericalmercator

Comment 6 Piotr Popieluch 2015-03-28 20:36:22 UTC

*** This bug has been marked as a duplicate of bug 914937 ***


Note You need to log in before you can comment on or make changes to this bug.