Bug 116666

Summary: network-functions:is_available() may leave with hotplug=/bin/true
Product: [Fedora] Fedora Reporter: Alexandre Oliva <oliva>
Component: initscriptsAssignee: Bill Nottingham <notting>
Status: CLOSED RAWHIDE QA Contact: Brock Organ <borgan>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: rvokal
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: 7.47-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-03-17 00:31:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 114961    
Attachments:
Description Flags
Patch that works around the behavioral changes in modprobe none

Description Alexandre Oliva 2004-02-24 09:24:59 UTC 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040217

Description of problem:
is_available contains such code as:

   HOTPLUG=`cat /proc/sys/kernel/hotplug`
    echo "/bin/true" > /proc/sys/kernel/hotplug
    modprobe $1 > /dev/null 2>&1 || return 1
    echo "$HOTPLUG"  > /proc/sys/kernel/hotplug

Not good if modprobe returns a non-zero exit status, which it quite
often does because of bug 116656.

The code right above that:

    alias=`modprobe -c | awk "/^(alias|install) $1 / { print \\$3 }"`
    if [ -z "$alias" -o "$alias" = "off" -o "$alias" = "/bin/true" ]; then

also fails with the new modprobe, per bug 116657.  alias will be set
to the module alias followed by /bin/true.

In general, none of this should matter, since we'll have already
loaded the modules, but if we haven't, this code will fail to do so.

Version-Release number of selected component (if applicable):
initscripts-7.46-1.1
Comment 1 Alexandre Oliva 2004-02-24 09:27:22 UTC 
Created attachment 97977 [details]
Patch that works around the behavioral changes in modprobe
Comment 2 Bill Nottingham 2004-03-17 00:31:27 UTC 
Hotplug resetting fixed in 7.47-1; the latter shouldn't be an issue
anymore.