Bug 1166925
| Summary: | Review Request: perl-Plack-Middleware-RemoveRedundantBody - Plack::Middleware which sets removes body for HTTP response if it's not required | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Dick <ddick> |
| Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jplesnik, package-review |
| Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Plack-Middleware-RemoveRedundantBody-0.05-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-06 02:33:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1166947 | ||
|
Description
David Dick
2014-11-22 01:00:30 UTC
koji builds rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=8205478 epel7 http://koji.fedoraproject.org/koji/taskinfo?taskID=8205480 Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
$ rpmlint ./perl-Plack-Middleware-FixMissingBodyInRedirect*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok
$ rpm -qp --requires perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc22.noarch.rpm | sort | uniq -c
1 perl(:MODULE_COMPAT_5.20.1)
1 perl(Plack::Middleware)
1 perl(Plack::Util)
1 perl(parent)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -qp --provides perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc22.noarch.rpm | sort | uniq -c
1 perl(Plack::Middleware::RemoveRedundantBody) = 0.04
1 perl-Plack-Middleware-RemoveRedundantBody = 0.05-1.fc22
The version of Plack::Middleware::RemoveRedundantBody should be 0.05.
Author forgot to update VERSION
./lib/Plack/Middleware/RemoveRedundantBody.pm:7:our $VERSION = "0.04";
Version was updated only at POD
./lib/Plack/Middleware/RemoveRedundantBody.pm:40:=head1 VERSION
./lib/Plack/Middleware/RemoveRedundantBody.pm:42:version 0.05
TODO: Please report it to upstream
Otherwise package looks good.
Package APPROVED.
Thanks Jitka! Most appreciated. New Package SCM Request ======================= Package Name: perl-Plack-Middleware-RemoveRedundantBody Short Description: Plack::Middleware which sets removes body for HTTP response if it's not required Owners: ddick Branches: f20 f21 epel7 InitialCC: perl-sig Git done (by process-git-requests). perl-Plack-Middleware-RemoveRedundantBody-0.05-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Plack-Middleware-RemoveRedundantBody-0.05-1.el7 perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc20 perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc21 perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc20 has been pushed to the Fedora 20 testing repository. perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc20 has been pushed to the Fedora 20 stable repository. perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc21 has been pushed to the Fedora 21 stable repository. perl-Plack-Middleware-RemoveRedundantBody-0.05-1.el7 has been pushed to the Fedora EPEL 7 stable repository. |