Bug 1166925 - Review Request: perl-Plack-Middleware-RemoveRedundantBody - Plack::Middleware which sets removes body for HTTP response if it's not required
Summary: Review Request: perl-Plack-Middleware-RemoveRedundantBody - Plack::Middleware...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1166947
TreeView+ depends on / blocked
 
Reported: 2014-11-22 01:00 UTC by David Dick
Modified: 2014-12-12 23:08 UTC (History)
2 users (show)

Fixed In Version: perl-Plack-Middleware-RemoveRedundantBody-0.05-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-06 02:33:41 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Dick 2014-11-22 01:00:30 UTC
Spec URL: https://ddick.fedorapeople.org/packages/perl-Plack-Middleware-RemoveRedundantBody.spec
SRPM URL: https://ddick.fedorapeople.org/packages/perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc20.src.rpm
Description: Plack::Middleware which sets removes body for HTTP response if it's not required
Fedora Account System Username: ddick

Comment 2 Jitka Plesnikova 2014-11-25 13:34:02 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpmlint ./perl-Plack-Middleware-FixMissingBodyInRedirect*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok


$ rpm -qp --requires perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc22.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Plack::Middleware)
      1 perl(Plack::Util)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc22.noarch.rpm | sort | uniq -c
      1 perl(Plack::Middleware::RemoveRedundantBody) = 0.04
      1 perl-Plack-Middleware-RemoveRedundantBody = 0.05-1.fc22

The version of Plack::Middleware::RemoveRedundantBody should be 0.05.

Author forgot to update VERSION
./lib/Plack/Middleware/RemoveRedundantBody.pm:7:our $VERSION = "0.04";

Version was updated only at POD
./lib/Plack/Middleware/RemoveRedundantBody.pm:40:=head1 VERSION
./lib/Plack/Middleware/RemoveRedundantBody.pm:42:version 0.05


TODO: Please report it to upstream

Otherwise package looks good.

Package APPROVED.

Comment 3 David Dick 2014-11-25 19:33:59 UTC
Thanks Jitka! Most appreciated.

New Package SCM Request
=======================
Package Name: perl-Plack-Middleware-RemoveRedundantBody
Short Description: Plack::Middleware which sets removes body for HTTP response if it's not required
Owners: ddick
Branches: f20 f21 epel7
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2014-11-25 20:58:38 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-11-26 05:37:00 UTC
perl-Plack-Middleware-RemoveRedundantBody-0.05-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/perl-Plack-Middleware-RemoveRedundantBody-0.05-1.el7

Comment 6 Fedora Update System 2014-11-26 05:41:07 UTC
perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc20

Comment 7 Fedora Update System 2014-11-26 09:23:41 UTC
perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc21

Comment 8 Fedora Update System 2014-11-27 08:35:06 UTC
perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 9 Fedora Update System 2014-12-06 02:33:41 UTC
perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 10 Fedora Update System 2014-12-06 10:44:15 UTC
perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 11 Fedora Update System 2014-12-12 23:08:58 UTC
perl-Plack-Middleware-RemoveRedundantBody-0.05-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.