Bug 1166984
| Summary: | Review Request: perl-Net-Whois-Raw - Get Whois information for domains | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Dick <ddick> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Net-Whois-Raw-2.76-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-13 09:46:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Dick
2014-11-22 11:09:03 UTC
koji builds rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=8208872 TIP: Move COPYRIGHT from %doc to %license (f21+).
FIX: BuildRequire %{_bindir}/iconv.
TODO: Useless BR -- ExtUtils::MakeMaker; you don't use the Makefile.PL at all.
TODO: You don't need to BR Getopt::Long or Net::IDN::Punycode either. The pwhois utility is not tested and the build script doesn't check for dependencies.
TODO: Useless explicit Requires in the main package; only the pwhois subpackage requires Net::IDN::Punycode.
TODO: Also, none of the tests seems to do any live testing, therefore there's no need to BR HTTP::Headers, HTTP::Request, LWP::UserAgent or URI::URL.
FIX: You still need to explicitly Require these as they will not be autodetected. And not just them -- rpmbuild also misses Data::Dumper.
TODO: I don't really like the %description of pwhois. I don't think it's the right place to list all the switches and such.
FIX: Since the pwhois subpackage doesn't explicitly require the main package, put COPYRIGHT in its %license or %doc too.
(In reply to Petr Šabata from comment #2) > TIP: Move COPYRIGHT from %doc to %license (f21+). I'd rather skip this as i'm planning on EPEL/f20 builds for this module > FIX: BuildRequire %{_bindir}/iconv. > > TODO: Useless BR -- ExtUtils::MakeMaker; you don't use the Makefile.PL at > all. > > TODO: You don't need to BR Getopt::Long or Net::IDN::Punycode either. The > pwhois utility is not tested and the build script doesn't check for > dependencies. > > TODO: Useless explicit Requires in the main package; only the pwhois > subpackage requires Net::IDN::Punycode. > > TODO: Also, none of the tests seems to do any live testing, therefore > there's no need to BR HTTP::Headers, HTTP::Request, LWP::UserAgent or > URI::URL. > > FIX: You still need to explicitly Require these as they will not be > autodetected. And not just them -- rpmbuild also misses Data::Dumper. > > TODO: I don't really like the %description of pwhois. I don't think it's > the right place to list all the switches and such. > > FIX: Since the pwhois subpackage doesn't explicitly require the main > package, put COPYRIGHT in its %license or %doc too. Fixed. Okay then. All points addressed. Approving. Thanks Petr! New Package SCM Request ======================= Package Name: perl-Net-Whois-Raw Short Description: Get Whois information for domains Owners: ddick Branches: f20 f21 el6 epel7 InitialCC: perl-sig Git done (by process-git-requests). perl-Net-Whois-Raw-2.76-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Net-Whois-Raw-2.76-1.fc21 perl-Net-Whois-Raw-2.76-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Net-Whois-Raw-2.76-1.fc20 perl-Net-Whois-Raw-2.76-1.fc21 has been pushed to the Fedora 21 testing repository. perl-Net-Whois-Raw-2.76-1.fc20 has been pushed to the Fedora 20 stable repository. perl-Net-Whois-Raw-2.76-1.fc21 has been pushed to the Fedora 21 stable repository. perl-Net-Whois-Raw-2.76-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Net-Whois-Raw-2.76-1.el7 perl-Net-Whois-Raw-2.76-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Net-Whois-Raw-2.76-1.el6 perl-Net-Whois-Raw-2.76-1.el6 has been pushed to the Fedora EPEL 6 stable repository. perl-Net-Whois-Raw-2.76-1.el7 has been pushed to the Fedora EPEL 7 stable repository. |