Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://ddick.fedorapeople.org/packages/perl-Net-Whois-Raw.spec SRPM URL: https://ddick.fedorapeople.org/packages/perl-Net-Whois-Raw-2.76-1.fc20.src.rpm Description: Get Whois information for domains Fedora Account System Username: ddick
koji builds rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=8208872
TIP: Move COPYRIGHT from %doc to %license (f21+). FIX: BuildRequire %{_bindir}/iconv. TODO: Useless BR -- ExtUtils::MakeMaker; you don't use the Makefile.PL at all. TODO: You don't need to BR Getopt::Long or Net::IDN::Punycode either. The pwhois utility is not tested and the build script doesn't check for dependencies. TODO: Useless explicit Requires in the main package; only the pwhois subpackage requires Net::IDN::Punycode. TODO: Also, none of the tests seems to do any live testing, therefore there's no need to BR HTTP::Headers, HTTP::Request, LWP::UserAgent or URI::URL. FIX: You still need to explicitly Require these as they will not be autodetected. And not just them -- rpmbuild also misses Data::Dumper. TODO: I don't really like the %description of pwhois. I don't think it's the right place to list all the switches and such. FIX: Since the pwhois subpackage doesn't explicitly require the main package, put COPYRIGHT in its %license or %doc too.
(In reply to Petr Šabata from comment #2) > TIP: Move COPYRIGHT from %doc to %license (f21+). I'd rather skip this as i'm planning on EPEL/f20 builds for this module > FIX: BuildRequire %{_bindir}/iconv. > > TODO: Useless BR -- ExtUtils::MakeMaker; you don't use the Makefile.PL at > all. > > TODO: You don't need to BR Getopt::Long or Net::IDN::Punycode either. The > pwhois utility is not tested and the build script doesn't check for > dependencies. > > TODO: Useless explicit Requires in the main package; only the pwhois > subpackage requires Net::IDN::Punycode. > > TODO: Also, none of the tests seems to do any live testing, therefore > there's no need to BR HTTP::Headers, HTTP::Request, LWP::UserAgent or > URI::URL. > > FIX: You still need to explicitly Require these as they will not be > autodetected. And not just them -- rpmbuild also misses Data::Dumper. > > TODO: I don't really like the %description of pwhois. I don't think it's > the right place to list all the switches and such. > > FIX: Since the pwhois subpackage doesn't explicitly require the main > package, put COPYRIGHT in its %license or %doc too. Fixed.
Okay then. All points addressed. Approving.
Thanks Petr! New Package SCM Request ======================= Package Name: perl-Net-Whois-Raw Short Description: Get Whois information for domains Owners: ddick Branches: f20 f21 el6 epel7 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Net-Whois-Raw-2.76-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Net-Whois-Raw-2.76-1.fc21
perl-Net-Whois-Raw-2.76-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Net-Whois-Raw-2.76-1.fc20
perl-Net-Whois-Raw-2.76-1.fc21 has been pushed to the Fedora 21 testing repository.
perl-Net-Whois-Raw-2.76-1.fc20 has been pushed to the Fedora 20 stable repository.
perl-Net-Whois-Raw-2.76-1.fc21 has been pushed to the Fedora 21 stable repository.
perl-Net-Whois-Raw-2.76-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Net-Whois-Raw-2.76-1.el7
perl-Net-Whois-Raw-2.76-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Net-Whois-Raw-2.76-1.el6
perl-Net-Whois-Raw-2.76-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
perl-Net-Whois-Raw-2.76-1.el7 has been pushed to the Fedora EPEL 7 stable repository.