Bug 1168523

Summary: Filter out rootpw from anaconda reports
Product: [Fedora] Fedora Reporter: Jakub Filak <jfilak>
Component: libreportAssignee: abrt <abrt-devel-list>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 20CC: abrt-devel-list, dvlasenk, extras-qa, iprikryl, jberan, jfilak, mhabrnal, mmilata, orion, rvokal, ssuehle, vpodzime
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: AcceptedFreezeException
Fixed In Version: abrt-2.2.2-2.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1041558 Environment:
Last Closed: 2015-04-28 12:59:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1041558    
Bug Blocks:    

Description Jakub Filak 2014-11-27 08:48:48 UTC
+++ This bug was initially created as a clone of Bug #1041558 +++

Description of problem:

It would be good if abrt filtered out "rootpw" lines from anaconda reports.  I know this is in the ks.cfg and the traceback files, perhaps others.

--- Additional comment from Orion Poplawski on 2014-11-05 00:48:44 CET ---

I think this is fairly important.  How can I help?

--- Additional comment from Jakub Filak on 2014-11-05 07:33:55 CET ---

It is already possible to highlight such lines, but auto-removing is not implemented yet. Would the highlighting be an acceptable solution to you?

--- Additional comment from Orion Poplawski on 2014-11-05 16:46:10 CET ---

It's better than nothing, but it should be auto-removed, especially since the text mode reporter makes it quite hard to find.

--- Additional comment from Jakub Filak on 2014-11-06 08:33:31 CET ---

Ah, I forgot on the text mode reporter. Hence I am adding a simple auto-remove utility for Anaconda reports in the following pull request:
https://github.com/abrt/libreport/pull/301

The pull request also enables highlighting of "rootpw" lines in the GUI reporter.

Vratislav, could you please take a look at that pull request?

--- Additional comment from Vratislav Podzimek on 2014-11-06 09:12:41 CET ---

(In reply to Jakub Filak from comment #4)
> Ah, I forgot on the text mode reporter. Hence I am adding a simple
> auto-remove utility for Anaconda reports in the following pull request:
> https://github.com/abrt/libreport/pull/301
Looks good to me.

--- Additional comment from Jakub Filak on 2014-11-26 11:06:51 CET ---

I opened another pull request for a patch making libreport aware of anaconda-tb:
https://github.com/abrt/libreport/pull/305

libreport cannot highlight all forbidden words in that file because the file contains too many false positives.

--- Additional comment from Orion Poplawski on 2014-11-26 16:18:33 CET ---

Would be nice to get this into F21 Final.

--- Additional comment from Scott Suehle on 2014-11-26 21:15:47 CET ---

Discussed at today's blocker review meeting [1]. Accepted as a AcceptedFreezeException. A fix for this would be considered during freeze.

[1] http://meetbot.fedoraproject.org/fedora-blocker-review/2014-11-12/

Comment 1 Fedora Update System 2015-02-16 13:56:09 UTC
abrt-2.2.2-2.fc20,libreport-2.2.3-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/abrt-2.2.2-2.fc20,libreport-2.2.3-3.fc20

Comment 2 Fedora Update System 2015-02-17 08:10:15 UTC
Package abrt-2.2.2-2.fc20, libreport-2.2.3-3.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing abrt-2.2.2-2.fc20 libreport-2.2.3-3.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-2191/abrt-2.2.2-2.fc20,libreport-2.2.3-3.fc20
then log in and leave karma (feedback).

Comment 3 Fedora Update System 2015-04-28 12:59:29 UTC
abrt-2.2.2-2.fc20, libreport-2.2.3-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.