Bug 1169332
| Summary: | Product CSS replaces (rather than supplementing) anaconda's, various visual problems in Product installs (no highlight in custom part, blue not orange, etc etc) | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kamil Páral <kparal> | ||||||||||||||||||
| Component: | fedora-productimg-workstation | Assignee: | Stephen Gallagher <sgallagh> | ||||||||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||||||||
| Priority: | unspecified | ||||||||||||||||||||
| Version: | 21 | CC: | awilliam, duffy, mattdm, mruckman, rlerch, sgallagh, stickster | ||||||||||||||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||
| Last Closed: | 2014-12-04 23:10:28 UTC | Type: | Bug | ||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||
| Embargoed: | |||||||||||||||||||||
| Bug Depends On: | |||||||||||||||||||||
| Bug Blocks: | 1043123 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Kamil Páral
2014-12-01 10:58:29 UTC
Created attachment 963229 [details]
custom-part-TC4.png
Created attachment 963230 [details]
custom-part-RC1.ogv
Created attachment 963231 [details]
warning-TC4.png
Created attachment 963232 [details]
warning-RC1.png
Created attachment 963233 [details]
password-TC4.png
Created attachment 963234 [details]
password-RC1.png
Created attachment 963235 [details]
rpm-qa.TC4
Created attachment 963236 [details]
rpm-qa.RC1
Proposing for a freeze exception, or potentially even a blocker, if we deem the custom partitioning issue as too important. For what it's worth, I'm -1 blocker on this. (In reply to Stephen Gallagher from comment #10) > For what it's worth, I'm -1 blocker on this. Disregard that. I started typing that, re-read the bit about the custom partitioning and changed my mind. I then CCed the people needed to fix it and forgot to remove my -1 blocker comment before hitting save. OK, so the problem here is that lorax is replacing the anaconda-gtk.css with the custom one contained in the fedora-productimg-* packages. The truly correct behavior would be for them to somehow make their way to /run/install/product/anaconda-gtk.css where anaconda would automatically merge them instead of replacing it. However, this is difficult to accomplish at this late stage, so our workaround will be to manually merge the CSS contents in the fedora-productimg-* packages so that the replacement results in the correct behavior. I'm working on this right now. Fixes are building in Koji right now. fedora-productimg-workstation-21-8.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/fedora-productimg-workstation-21-8.fc21 fedora-productimg-server-21-8.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/fedora-productimg-server-21-8.fc21 fedora-productimg-cloud-21-8.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/fedora-productimg-cloud-21-8.fc21 (Three separate updates, since the packages conflict and bodhi doesn't let them go together. I marked the workstation one as closing this bug, as it's the most visible, but the server one is obviously pretty important too -- probably that's where the angry messages about custom partitioning will be clustered....) Discussed in 2014-12-01 blocker review meeting. Accepted as an FE: the combination of broken elements here leads to a significantly degraded user experience, and is a clear regression from all previous tested composes. Package fedora-productimg-workstation-21-8.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing fedora-productimg-workstation-21-8.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-16088/fedora-productimg-workstation-21-8.fc21 then log in and leave karma (feedback). Fix for this looks good in RC2. fedora-productimg-workstation-21-8.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. fedora-productimg-cloud-21-8.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. fedora-productimg-server-21-8.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. Re-opening for Rawhide, this is not addressed there yet. This was Final FE for F21, propose Alpha FE for F22, it's pretty ugly and makes custom part a bit confusing. Should it be against anaconda for F22, to merge CSS instead of replacing it? Ah. "The truly correct behavior would be for them to somehow make their way to /run/install/product/anaconda-gtk.css where anaconda would automatically merge them instead of replacing it." so, no. (In reply to Adam Williamson (Red Hat) from comment #26) > Ah. "The truly correct behavior would be for them to somehow make their way > to /run/install/product/anaconda-gtk.css where anaconda would automatically > merge them instead of replacing it." > > so, no. I think #1170800 supplants this for rawhide. Fair enough. |