Bug 1170825

Summary:	GlusterFS logrotate config complains about missing files
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	logging	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	Patch, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1170814	Environment:
Last Closed:	2015-05-14 17:28:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1165133, 1170814

Description Niels de Vos 2014-12-04 22:56:27 UTC

+++ This bug was initially created as a clone of Bug #1170814 +++

Description of problem:
The supplied logrotate configuration in extras/glusterfs-georep-logrotate causes errors for every logrotate execution due to the definition of "/var/log/glusterfs/geo-replication-slaves/*/*.log".

The missingok directive is inbetween postrotate and endscript, it needs to be mmoved before the postrotate directive.

Version-Release number of selected component (if applicable):
3.6.1

How reproducible:
Every time.

Steps to Reproduce:
Call `logrotate /etc/logrotate.conf' with glusterfs logrotate config from: extras/glusterfs-georep-logrotate in "/etc/logrotate.d/".

Actual results:
error: glusterfs-georep:31 glob failed for /var/log/glusterfs/geo-replication-slaves/*/*.log: No such file or directory
error: found error in file glusterfs-georep, skipping

Expected results:
No error message at all.

Additional info:

--- Additional comment from Anand Avati on 2014-12-04 23:46:39 CET ---

REVIEW: http://review.gluster.org/9239 (Stop logrotate from complaining about missing files.) posted (#1) for review on release-3.6 by Jan-Hendrik Zab (zab)

Comment 1 Anand Avati 2014-12-10 14:31:25 UTC

REVIEW: http://review.gluster.org/9264 (Stop logrotate from complaining about missing files.) posted (#1) for review on master by Jan-Hendrik Zab (zab)

Comment 2 Anand Avati 2014-12-11 08:04:41 UTC

COMMIT: http://review.gluster.org/9264 committed in master by Niels de Vos (ndevos) 
------
commit e679d6417d39a696126e3f7ede1f2f38afc6e44c
Author: Jan-Hendrik Zab <zab>
Date:   Thu Dec 4 23:41:09 2014 +0100

    Stop logrotate from complaining about missing files.
    
    Previously logrotate reported errors for files missing in
    "/var/log/glusterfs/geo-replication-slaves/*/*.log". Fixed by reordering
    directives in the example config.
    
    Change-Id: I7cdb9e0d82f08aa27d5e26664660204fdeb8e98e
    BUG: 1170825
    Signed-off-by: Jan-Hendrik Zab <zab>
    Reviewed-on: http://review.gluster.org/9264
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Lalatendu Mohanty <lmohanty>

Comment 3 Niels de Vos 2015-05-14 17:28:39 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:35:45 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:07 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:45:14 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user