Bug 1171236

Source2 doesn't exist anymore in master, upstream moved test to separate directory. Please specify the tag in the Sources, like
Source2: https://raw.githubusercontent.com/sindresorhus/got/v2.2.0/test.js

APPROVED but:
- please update to latest upstream version
- specify version tags in source tags
- check if tests can be enabled
before pushing to upstream


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 2 files have unknown license. Detailed output of
     licensecheck in /home/piotr/rpmbuild/1171236-nodejs-got/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source2:
     https://raw.githubusercontent.com/sindresorhus/got/master/test.js
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-got-2.1.0-1.fc22.noarch.rpm
          nodejs-got-2.1.0-1.fc22.src.rpm
nodejs-got.noarch: W: spelling-error %description -l en_US http -> HTTP
nodejs-got.noarch: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically
nodejs-got.noarch: W: spelling-error %description -l en_US gzip -> zip, grip, g zip
nodejs-got.noarch: W: only-non-binary-in-usr-lib
nodejs-got.noarch: W: dangling-symlink /usr/lib/node_modules/got/node_modules/object-assign /usr/lib/node_modules/object-assign
nodejs-got.noarch: W: dangling-symlink /usr/lib/node_modules/got/node_modules/read-all-stream /usr/lib/node_modules/read-all-stream
nodejs-got.noarch: W: dangling-symlink /usr/lib/node_modules/got/node_modules/timed-out /usr/lib/node_modules/timed-out
nodejs-got.src: W: spelling-error %description -l en_US http -> HTTP
nodejs-got.src: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically
nodejs-got.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip
nodejs-got.src: W: invalid-url Source2: https://raw.githubusercontent.com/sindresorhus/got/master/test.js HTTP Error 404: Not Found
2 packages and 0 specfiles checked; 0 errors, 11 warnings.




Rpmlint (installed packages)
----------------------------
]0;<mock-chroot><mock-chroot>[root@pontifex /]# rpmlint nodejs-got
nodejs-got.noarch: W: spelling-error %description -l en_US http -> HTTP
nodejs-got.noarch: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically
nodejs-got.noarch: W: spelling-error %description -l en_US gzip -> zip, grip, g zip
nodejs-got.noarch: W: only-non-binary-in-usr-lib
nodejs-got.noarch: W: dangling-symlink /usr/lib/node_modules/got/node_modules/object-assign /usr/lib/node_modules/object-assign
nodejs-got.noarch: W: dangling-symlink /usr/lib/node_modules/got/node_modules/read-all-stream /usr/lib/node_modules/read-all-stream
nodejs-got.noarch: W: dangling-symlink /usr/lib/node_modules/got/node_modules/timed-out /usr/lib/node_modules/timed-out
1 packages and 0 specfiles checked; 0 errors, 7 warnings.
]0;<mock-chroot><mock-chroot>[root@pontifex /]# echo 'rpmlint-done:'



Requires
--------
nodejs-got (rpmlib, GLIBC filtered):
    nodejs(engine)
    npm(object-assign)
    npm(read-all-stream)
    npm(timed-out)



Provides
--------
nodejs-got:
    nodejs-got
    npm(got)



Source checksums
----------------
http://registry.npmjs.org/got/-/got-2.1.0.tgz :
  CHECKSUM(SHA256) this package     : bb5dc2cfbf9a0558994c71ad7a5ee10dbcae74c970cbf17e51a979d05d2ca49e
  CHECKSUM(SHA256) upstream package : bb5dc2cfbf9a0558994c71ad7a5ee10dbcae74c970cbf17e51a979d05d2ca49e
https://raw.githubusercontent.com/sindresorhus/got/master/license :
  CHECKSUM(SHA256) this package     : 6fb9754611c20f6649f68805e8c990e83261f29316e29de9e6cedae607b8634c
  CHECKSUM(SHA256) upstream package : 6fb9754611c20f6649f68805e8c990e83261f29316e29de9e6cedae607b8634c


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1171236
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Thank you for this package review.

New Package SCM Request
=======================
Package Name: nodejs-got
Short Description: Simplified HTTP/HTTPS requests
Upstream URL: https://github.com/sindresorhus/got
Owners: pnemade
Branches: f20 f21 el6 epel7
InitialCC:

Git done (by process-git-requests).

I will build this with new version (disabled tests) but looks like enabling tests require few more packages to be added to fedora which I will do in next few days.

nodejs-got-2.2.0-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-got-2.2.0-1.fc21

nodejs-got-2.2.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/nodejs-got-2.2.0-1.el6

nodejs-got-2.2.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-got-2.2.0-1.fc20

nodejs-got-2.2.0-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-got-2.2.0-1.el7

This is now built for all requested branches.

nodejs-got-2.2.0-1.fc21 has been pushed to the Fedora 21 stable repository.

nodejs-got-2.2.0-1.fc20 has been pushed to the Fedora 20 stable repository.

nodejs-got-2.2.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.

nodejs-got-2.2.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.