Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-read-all-stream.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-read-all-stream-0.1.2-1.fc21.src.rpm Description: Read all stream content and pass it to callback. Fedora Account System Username: pnemade
upstream test.js is failing so disabled tests Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-read-all-stream.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-read-all-stream-0.1.2-2.fc21.src.rpm
License in srpm differs from upstream, please download license from upstream and rebuild srpm before pushing to SCM APPROVED cat nodejs-read-all-stream/diff.txt diff -U2 -r /home/piotr/rpmbuild/nodejs-read-all-stream/upstream-unpacked/Source1/license /home/piotr/rpmbuild/nodejs-read-all-stream/srpm-unpacked/license-extract/license --- /home/piotr/rpmbuild/nodejs-read-all-stream/upstream-unpacked/Source1/license 2014-12-07 19:17:01.262835277 +0100 +++ /home/piotr/rpmbuild/nodejs-read-all-stream/srpm-unpacked/license-extract/license 2014-12-07 19:17:01.281835488 +0100 @@ -1,5 +1,5 @@ The MIT License (MIT) -Copyright (c) Vsevolod Strukchinsky <floatdrop> +Copyright (c) Sindre Sorhus <sindresorhus> (sindresorhus.com) Permission is hereby granted, free of charge, to any person obtaining a copy Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/piotr/rpmbuild/nodejs- read-all-stream/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/piotr/rpmbuild/nodejs-read-all- stream/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: nodejs-read-all-stream-0.1.2-2.fc21.noarch.rpm nodejs-read-all-stream-0.1.2-2.fc21.src.rpm nodejs-read-all-stream.noarch: W: only-non-binary-in-usr-lib nodejs-read-all-stream.src: W: file-size-mismatch license = 1119, https://raw.githubusercontent.com/floatdrop/read-all-stream/master/license = 1105 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-read-all-stream nodejs-read-all-stream.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- nodejs-read-all-stream (rpmlib, GLIBC filtered): nodejs(engine) Provides -------- nodejs-read-all-stream: nodejs-read-all-stream npm(read-all-stream) Source checksums ---------------- https://raw.githubusercontent.com/floatdrop/read-all-stream/master/test.js : CHECKSUM(SHA256) this package : 24e64cbd771c6e8d702a150889749f9d4d3bbe982c9aed708dbce780dfc3174d CHECKSUM(SHA256) upstream package : 24e64cbd771c6e8d702a150889749f9d4d3bbe982c9aed708dbce780dfc3174d http://registry.npmjs.org/read-all-stream/-/read-all-stream-0.1.2.tgz : CHECKSUM(SHA256) this package : af8e264b2772a6d9a05582aa5582977ae789711c66411bcf89c9c1c0f3208b5b CHECKSUM(SHA256) upstream package : af8e264b2772a6d9a05582aa5582977ae789711c66411bcf89c9c1c0f3208b5b https://raw.githubusercontent.com/floatdrop/read-all-stream/master/license : CHECKSUM(SHA256) this package : 6fb9754611c20f6649f68805e8c990e83261f29316e29de9e6cedae607b8634c CHECKSUM(SHA256) upstream package : e19885e03f3554a6725a89ba1ff33015589c6e2edb2f939e04d10a26db33d6ef diff -r also reports differences Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review --rpm-spec -n /home/piotr/rpmbuild/SRPMS/nodejs-read-all-stream-0.1.2-2.fc21.src.rpm Buildroot used: fedora-21-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
sorry for this confusion. I have fixed this in below update. no release bump. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-read-all-stream.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-read-all-stream-0.1.2-2.fc21.src.rpm
Thank you for this review. New Package SCM Request ======================= Package Name: nodejs-read-all-stream Short Description: Read all stream content and pass it to callback Upstream URL: https://github.com/floatdrop/read-all-stream Owners: pnemade Branches: f19 f20 f21 el6 epel7 InitialCC:
nodejs-read-all-stream-0.1.2-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-read-all-stream-0.1.2-2.fc21
nodejs-read-all-stream-0.1.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-read-all-stream-0.1.2-2.fc20
nodejs-read-all-stream-0.1.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-read-all-stream-0.1.2-2.fc19
nodejs-read-all-stream-0.1.2-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-read-all-stream-0.1.2-2.el7
nodejs-read-all-stream-0.1.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-read-all-stream-0.1.2-2.el6
Closing this review as package is built now,
nodejs-read-all-stream-0.1.2-2.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-read-all-stream-0.1.2-2.fc19 has been pushed to the Fedora 19 stable repository.
nodejs-read-all-stream-0.1.2-2.fc21 has been pushed to the Fedora 21 stable repository.
nodejs-read-all-stream-0.1.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
nodejs-read-all-stream-0.1.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository.