Bug 1172210
| Summary: | Review Request: perl-Git-Repository-Plugin-AUTOLOAD - Git subcommands as Git::Repository methods | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Šabata <psabata> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-10 16:01:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1163236 | ||
|
Description
Petr Šabata
2014-12-09 15:46:16 UTC
URL and Source0 are usable. Ok.
Source0 archive is original (SHA-256: 3e0ad1d850880e3f79b7dd70f25234108b4185aa53c3ccccd6acebecf4b66722). Ok.
Summary verified from lib/Git/Repository/Plugin/AUTOLOAD.pm. Ok.
Description verified from lib/Git/Repository/Plugin/AUTOLOAD.pm. Ok.
License verified from lib/Git/Repository/Plugin/AUTOLOAD.pm and LICESNE. Ok.
No XS code, noarch BuildArch is Ok.
All build-time dependencies are specified. Ok.
All tests pass.
$ rpmlint perl-Git-Repository-Plugin-AUTOLOAD.spec ../SRPMS/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.src.rpm ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm
perl-Git-Repository-Plugin-AUTOLOAD.src: W: spelling-error Summary(en_US) subcommands -> sub commands, sub-commands, commands
perl-Git-Repository-Plugin-AUTOLOAD.src: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically
perl-Git-Repository-Plugin-AUTOLOAD.noarch: W: spelling-error Summary(en_US) subcommands -> sub commands, sub-commands, commands
perl-Git-Repository-Plugin-AUTOLOAD.noarch: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm
drwxr-xr-x 2 root root 0 Dec 9 17:12 /usr/share/doc/perl-Git-Repository-Plugin-AUTOLOAD
-rw-r--r-- 1 root root 296 Feb 23 2014 /usr/share/doc/perl-Git-Repository-Plugin-AUTOLOAD/Changes
drwxr-xr-x 2 root root 0 Dec 9 17:12 /usr/share/licenses/perl-Git-Repository-Plugin-AUTOLOAD
-rw-r--r-- 1 root root 18377 Feb 23 2014 /usr/share/licenses/perl-Git-Repository-Plugin-AUTOLOAD/LICENSE
-rw-r--r-- 1 root root 2164 Dec 9 17:12 /usr/share/man/man3/Git::Repository::Plugin::AUTOLOAD.3pm.gz
drwxr-xr-x 2 root root 0 Dec 9 17:12 /usr/share/perl5/vendor_perl/Git
drwxr-xr-x 2 root root 0 Dec 9 17:12 /usr/share/perl5/vendor_perl/Git/Repository
drwxr-xr-x 2 root root 0 Dec 9 17:12 /usr/share/perl5/vendor_perl/Git/Repository/Plugin
-rw-r--r-- 1 root root 2617 Feb 23 2014 /usr/share/perl5/vendor_perl/Git/Repository/Plugin/AUTOLOAD.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm | sort -f | uniq -c
1 perl >= 0:5.006
1 perl(:MODULE_COMPAT_5.20.1)
1 perl(Git::Repository::Plugin)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm | sort -f | uniq -c
1 perl(Git::Repository::Plugin::AUTOLOAD) = 1.001
1 perl-Git-Repository-Plugin-AUTOLOAD = 1.001-1.fc22
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8330045). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-Git-Repository-Plugin-AUTOLOAD Short Description: Git subcommands as Git::Repository methods Upstream URL: http://search.cpan.org/dist/Git-Repository-Plugin-AUTOLOAD/ Owners: psabata jplesnik ppisar Branches: InitialCC: perl-sig Git done (by process-git-requests). Thanks. |