Bug 1172210 - Review Request: perl-Git-Repository-Plugin-AUTOLOAD - Git subcommands as Git::Repository methods
Summary: Review Request: perl-Git-Repository-Plugin-AUTOLOAD - Git subcommands as Git:...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1163236
TreeView+ depends on / blocked
 
Reported: 2014-12-09 15:46 UTC by Petr Šabata
Modified: 2014-12-10 16:01 UTC (History)
2 users (show)

Fixed In Version: perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22
Clone Of:
Environment:
Last Closed: 2014-12-10 16:01:15 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2014-12-09 15:46:16 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Git-Repository-Plugin-AUTOLOAD/perl-Git-Repository-Plugin-AUTOLOAD.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Git-Repository-Plugin-AUTOLOAD/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc20.src.rpm
Description:
This module adds an AUTOLOAD method to Git::Repository, enabling it to
automagically call git commands as methods on Git::Repository objects.
Fedora Account System Username: psabata

Comment 1 Petr Pisar 2014-12-09 16:24:30 UTC
URL and Source0 are usable. Ok.
Source0 archive is original (SHA-256: 3e0ad1d850880e3f79b7dd70f25234108b4185aa53c3ccccd6acebecf4b66722). Ok.
Summary verified from lib/Git/Repository/Plugin/AUTOLOAD.pm. Ok.
Description verified from lib/Git/Repository/Plugin/AUTOLOAD.pm. Ok.
License verified from lib/Git/Repository/Plugin/AUTOLOAD.pm and LICESNE. Ok.
No XS code, noarch BuildArch is Ok.
All build-time dependencies are specified. Ok.
All tests pass.

$ rpmlint perl-Git-Repository-Plugin-AUTOLOAD.spec ../SRPMS/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.src.rpm ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm 
perl-Git-Repository-Plugin-AUTOLOAD.src: W: spelling-error Summary(en_US) subcommands -> sub commands, sub-commands, commands
perl-Git-Repository-Plugin-AUTOLOAD.src: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically
perl-Git-Repository-Plugin-AUTOLOAD.noarch: W: spelling-error Summary(en_US) subcommands -> sub commands, sub-commands, commands
perl-Git-Repository-Plugin-AUTOLOAD.noarch: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Dec  9 17:12 /usr/share/doc/perl-Git-Repository-Plugin-AUTOLOAD
-rw-r--r--    1 root    root                      296 Feb 23  2014 /usr/share/doc/perl-Git-Repository-Plugin-AUTOLOAD/Changes
drwxr-xr-x    2 root    root                        0 Dec  9 17:12 /usr/share/licenses/perl-Git-Repository-Plugin-AUTOLOAD
-rw-r--r--    1 root    root                    18377 Feb 23  2014 /usr/share/licenses/perl-Git-Repository-Plugin-AUTOLOAD/LICENSE
-rw-r--r--    1 root    root                     2164 Dec  9 17:12 /usr/share/man/man3/Git::Repository::Plugin::AUTOLOAD.3pm.gz
drwxr-xr-x    2 root    root                        0 Dec  9 17:12 /usr/share/perl5/vendor_perl/Git
drwxr-xr-x    2 root    root                        0 Dec  9 17:12 /usr/share/perl5/vendor_perl/Git/Repository
drwxr-xr-x    2 root    root                        0 Dec  9 17:12 /usr/share/perl5/vendor_perl/Git/Repository/Plugin
-rw-r--r--    1 root    root                     2617 Feb 23  2014 /usr/share/perl5/vendor_perl/Git/Repository/Plugin/AUTOLOAD.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm | sort -f | uniq -c
      1 perl >= 0:5.006
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Git::Repository::Plugin)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm | sort -f | uniq -c
      1 perl(Git::Repository::Plugin::AUTOLOAD) = 1.001
      1 perl-Git-Repository-Plugin-AUTOLOAD = 1.001-1.fc22
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8330045). Ok.

Package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.

Comment 2 Petr Šabata 2014-12-09 16:45:26 UTC
New Package SCM Request
=======================
Package Name: perl-Git-Repository-Plugin-AUTOLOAD
Short Description: Git subcommands as Git::Repository methods
Upstream URL: http://search.cpan.org/dist/Git-Repository-Plugin-AUTOLOAD/
Owners: psabata jplesnik ppisar
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2014-12-10 15:36:17 UTC
Git done (by process-git-requests).

Comment 4 Petr Šabata 2014-12-10 16:01:15 UTC
Thanks.


Note You need to log in before you can comment on or make changes to this bug.