Bug 1173420
| Summary: | report error when set too large max_sectors for controller | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Luyao Huang <lhuang> |
| Component: | libvirt | Assignee: | Martin Kletzander <mkletzan> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.1 | CC: | dyuan, mkletzan, mzhan, rbalakri |
| Target Milestone: | rc | Keywords: | Upstream |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-1.2.13-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-11-19 05:58:09 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Fixed upstream by v1.2.11-rc2-6-gce1d2f6:
commit ce1d2f63152290098450fa2beecdee79cf929456
Author: Luyao Huang <lhuang>
Date: Fri Dec 12 10:32:54 2014 +0800
conf: goto error when value of max_sectors is too large
Verified as below:
[root@localhost ~]# rpm -q libvirt
libvirt-1.2.15-1.el7.x86_64
Add below controller with invalid max_sectors into domain
<controller type='scsi' index='0' model='virtio-scsi'>
<driver max_sectors='12345678676754'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</controller>
[root@localhost ~]# virsh edit r71
error: XML document failed to validate against schema: Unable to validate doc against /usr/share/libvirt/schemas/domain.rng
Extra element devices in interleave
Element domain failed to validate content
Failed. Try again? [y,n,i,f,?]: <=== press "i"
error: XML error: Malformed 'max_sectors' value 12345678676754'
Failed. Try again? [y,n,f,?]:
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Log from libvirtd.log
For the first time:
2015-05-07 08:13:17.776+0000: 7096: debug : virFileFindResourceFull:1666 : Resolved 'domain.rng' to '/usr/share/libvirt/schemas/domain.rng'
2015-05-07 08:13:17.783+0000: 7096: error : virXMLValidateAgainstSchema:1151 : XML document failed to validate against schema: Unable to validate doc against /usr/share/libvirt/schemas/domain.rng
Extra element devices in interleave
Element domain failed to validate content
For the second time:
957 2015-05-07 08:13:21.426+0000: 7099: info : virObjectRef:296 : OBJECT_REF: obj=0x7fdf842323f0
958 2015-05-07 08:13:21.426+0000: 7099: error : virDomainControllerDefParseXML:7342 : XML error: Malformed 'max_sectors' value 12345678676754'
959 2015-05-07 08:13:21.426+0000: 7099: info : virObjectUnref:259 : OBJECT_UNREF: obj=0x7fdf842323f0
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2202.html |
Description of problem: report error when set too large max_sectors for controller Version-Release number of selected component (if applicable): libvirt-1.2.8-10.el7.x86_64 How reproducible: 100% Steps: 1. try to edit xml like this: # virsh edit test4 <controller type='scsi' index='0' model='virtio-scsi'> <driver max_sectors='12345678676754'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </controller> 2.check the log 2014-12-12 02:36:37.133+0000: 27650: error : virDomainControllerDefParseXML:6504 : XML error: Malformed 'max_sectors' value 12345678676754' 3.check the XML controller disappear Actual results: no output max_sectors disappear Expected results: error output when save xml Additional info: I have send a patch to upstream: http://www.redhat.com/archives/libvir-list/2014-December/msg00653.html