RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1173420 - report error when set too large max_sectors for controller
Summary: report error when set too large max_sectors for controller
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.1
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Martin Kletzander
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-12 05:36 UTC by Luyao Huang
Modified: 2015-11-19 05:58 UTC (History)
4 users (show)

Fixed In Version: libvirt-1.2.13-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-19 05:58:09 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:2202 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2015-11-19 08:17:58 UTC

Description Luyao Huang 2014-12-12 05:36:24 UTC 
Description of problem:
report error when set too large max_sectors for controller


Version-Release number of selected component (if applicable):
libvirt-1.2.8-10.el7.x86_64

How reproducible:
100%

Steps:

1.
try to edit xml like this:
# virsh edit test4
    <controller type='scsi' index='0' model='virtio-scsi'>
<driver max_sectors='12345678676754'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
    </controller>

2.check the log

2014-12-12 02:36:37.133+0000: 27650: error : virDomainControllerDefParseXML:6504 : XML error: Malformed 'max_sectors' value 12345678676754'

3.check the XML controller disappear

Actual results:
no output max_sectors disappear

      
Expected results:
error output when save xml


Additional info:

I have send a patch to upstream:

http://www.redhat.com/archives/libvir-list/2014-December/msg00653.html
Comment 1 Martin Kletzander 2014-12-12 06:22:52 UTC 
Fixed upstream by v1.2.11-rc2-6-gce1d2f6:

commit ce1d2f63152290098450fa2beecdee79cf929456
Author: Luyao Huang <lhuang>
Date:   Fri Dec 12 10:32:54 2014 +0800

    conf: goto error when value of max_sectors is too large
Comment 3 Hu Jianwei 2015-05-07 08:18:45 UTC 
Verified as below:

[root@localhost ~]# rpm -q libvirt
libvirt-1.2.15-1.el7.x86_64

Add below controller with invalid max_sectors into domain
    <controller type='scsi' index='0' model='virtio-scsi'>
<driver max_sectors='12345678676754'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
    </controller>

[root@localhost ~]# virsh edit r71
error: XML document failed to validate against schema: Unable to validate doc against /usr/share/libvirt/schemas/domain.rng
Extra element devices in interleave
Element domain failed to validate content

Failed. Try again? [y,n,i,f,?]:        <=== press "i"
error: XML error: Malformed 'max_sectors' value 12345678676754'
Failed. Try again? [y,n,f,?]: 

+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Log from libvirtd.log
For the first time:
2015-05-07 08:13:17.776+0000: 7096: debug : virFileFindResourceFull:1666 : Resolved 'domain.rng' to '/usr/share/libvirt/schemas/domain.rng'
2015-05-07 08:13:17.783+0000: 7096: error : virXMLValidateAgainstSchema:1151 : XML document failed to validate against schema: Unable to validate doc against /usr/share/libvirt/schemas/domain.rng
Extra element devices in interleave
Element domain failed to validate content

For the second time:
 957 2015-05-07 08:13:21.426+0000: 7099: info : virObjectRef:296 : OBJECT_REF: obj=0x7fdf842323f0
 958 2015-05-07 08:13:21.426+0000: 7099: error : virDomainControllerDefParseXML:7342 : XML error: Malformed 'max_sectors' value 12345678676754'
 959 2015-05-07 08:13:21.426+0000: 7099: info : virObjectUnref:259 : OBJECT_UNREF: obj=0x7fdf842323f0
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comment 5 errata-xmlrpc 2015-11-19 05:58:09 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2202.html
Note You need to log in before you can comment on or make changes to this bug.