Bug 1175299 (kf5-ksysguard, libksysguard)
| Summary: | Review Request: libksysguard - KDE Frameworks 5 Tier 3 addon for process management | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Grulich <jgrulich> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dvratil, package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-01-29 15:00:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1135103, 1175302 | ||
|
Description
Jan Grulich
2014-12-17 13:16:05 UTC
naming: ok (though I'd prefer to use the upstream name here: libksysguard) sources: ok 05edba7e9c155008e8b26d15756b355c libksysguard-5.1.1.tar.xz 1. SHOULD use better project url, suggest URL: https://projects.kde.org/projects/kde/workspace/libksysguard macros: ok (mostly...) 2. SHOULD prefer/use make install/fast DESTDIR=%{buildroot} over %make_install scriptlets: ok no MUST blockers, APPROVED. naming: I guess libksysguard is going to be a framework, they even called the library KF5SysGuard so I would prefer to use kf5 prefix to avoid renaming it in future. 1-2. Fixed Spec URL: https://jgrulich.fedorapeople.org/plasma5/kf5-ksysguard.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/kf5-ksysguard-5.1.1-1.fc21.src.rpm New Package SCM Request ======================= Package Name: kf5-ksysguard Short Description: KDE Frameworks 5 Tier 3 addon for process management Upstream URL: https://projects.kde.org/projects/kde/workspace/powerdevil Owners: rdieter kkofler dvratil than jgrulich ltinkl Branches: f20 f21 InitialCC: kde-sig Sorry, I forgot to change the URL. Correct SCM request below. New Package SCM Request ======================= Package Name: kf5-ksysguard Short Description: KDE Frameworks 5 Tier 3 addon for process management Upstream URL: https://projects.kde.org/projects/kde/workspace/libksysguard Owners: rdieter kkofler dvratil than jgrulich ltinkl Branches: f20 f21 InitialCC: kde-sig One more time. New Package SCM Request ======================= Package Name: kf5-ksysguard Short Description: KDE Frameworks 5 Tier 3 addon for process management Upstream URL: https://projects.kde.org/projects/kde/workspace/libksysguard Owners: @kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f20 f21 InitialCC: New Package SCM Request ======================= Package Name: kf5-ksysguard Short Description: KDE Frameworks 5 Tier 3 addon for process management Upstream URL: https://projects.kde.org/projects/kde/workspace/libksysguard Owners: group::kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f20 f21 InitialCC: WARNING: "group::kde-sig" is not a valid FAS account. New Package SCM Request ======================= Package Name: kf5-ksysguard Short Description: KDE Frameworks 5 Tier 3 addon for process management Upstream URL: https://projects.kde.org/projects/kde/workspace/libksysguard Owners: rdieter kkofler dvratil than jgrulich ltinkl Branches: f20 f21 InitialCC: Git done (by process-git-requests). > naming: I guess libksysguard is going to be a framework, they even called the
> library KF5SysGuard so I would prefer to use kf5 prefix to avoid renaming it in
> future.
That's not true. The "KF5" naming scheme is added by the patch that I added. That was back when it wasn't clear where libksysguard is going. Now it's clear it's going to remain in workspace. Unfortunately I caught this too late, but would anyone object against dropping kf5-ksysguard repo and instead importing this as libksysguard following the upstream naming, as Rex suggested?
If it's not going to be a framework I don't see any reason why we should keep the kf5 prefix. No objection, Mind posting a new .spec for quick review of upgrade path (ie, Obsoletes, etc...)? Spec URL: https://jgrulich.fedorapeople.org/plasma5/libksysguard.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/libksysguard-5.1.1-3.fc21.src.rpm Description: KSysGuard library provides API to read and manage processes running on the system. Fedora Account System Username: jgrulich Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8675583 * Tue Jan 20 2015 Jan Grulich <jgrulich> - 5.1.1-3 - Rename to libksysguard I don't see any Obsoletes for upgrade path, I'd suggest adding in main:
Obsoletes: kf5-sysguard < 5.1.1-3
Provides: kf5-sysguard = %{version}-%{release}
and to -devel:
Obsoletes: kf5-sysguard-devel < 5.1.1-3
Provides: kf5-sysguard-devel = %{version}-%{release}
oops, typo make that kf5-ksysguard (instead of kf5-sysguard) Spec URL: https://jgrulich.fedorapeople.org/plasma5/libksysguard.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/libksysguard-5.1.1-4.fc21.src.rpm * Wed Jan 21 2015 Jan Grulich <jgrulich> - 5.1.1-4 - Obsolete kf5-ksysguard Better, let's go with that. New Package SCM Request ======================= Package Name: libksysguard Short Description: KDE process management library Upstream URL: https://projects.kde.org/projects/kde/workspace/libksysguard Owners: group::kde-sig Branches: InitialCC: Rex, could you please retire the kf5-ksysguard package in pkgdb? I pushed dead.package, but apparently can't retire from pkgdb - you are listed as the main contact there, so you should be able to do so. old one retired Git done (by process-git-requests). |