Spec URL: https://jgrulich.fedorapeople.org/plasma5/ksysguard.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/ksysguard-5.1.1-1.fc21.src.rpm Description: Performance monitor daemon Fedora Account System Username: jgrulich
naming: ok 1. SHOULD use better project url, suggest: URL: https://projects.kde.org/projects/kde/workspace/ksysguard 2. license NOT ok, some sources are GPLv2 only so MUST use: License: GPLv2 sources: ok 3b2e23fc9e758741f26d1edb6120ea3d ksysguard-5.1.1.tar.xz 3. SHOULD prefer/use make install/fast DESTDIR=%{buildroot} over %make_install 4. SHOULD verify if scriptlets %post -p /sbin/ldconfig %postun -p /sbin/ldconfig are needed for special-case kdeinit shlib: %{_kf5_libdir}/libkdeinit5_ksysguard.so 5. MUST validate included application .desktop file, add BuildRequires: desktop-file-utils and %check desktop-file-validate %{buildroot}%{_datadir}/applications/ksysguard.desktop 6. MUST add icon cache scriptlets for included %{_datadir}/icons/hicolor/*/apps/*.png 7. SHOULD use %find_lang ... --with-kde ... to automatically pick up HTML handbooks
- Fixed license - Used make install instead of make_install macro - Removed unnecessary scriptlets and added scriptlets for icon cache - Added desktop file validation Spec URL: https://jgrulich.fedorapeople.org/plasma5/ksysguard.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/ksysguard-5.1.1-2.fc21.src.rpm
Rex, could you please finish the review, since you started with it?
All MUST blocker items resolved, APPROVED (though consider item 7 not implemented yet afaict).
New Package SCM Request ======================= Package Name: ksysguard Short Description: KDE Process Management application Upstream URL: https://projects.kde.org/projects/kde/workspace/ksysguard Owners: group::kde-sig Branches: f20 f21 InitialCC:
Git done (by process-git-requests).