Bug 1175302 (ksysguard)

Summary:	Review Request: ksysguard - KDE Process Management application
Product:	[Fedora] Fedora	Reporter:	Jan Grulich <jgrulich>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dvratil, jgrulich, package-review, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-01-20 13:41:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1175299
Bug Blocks:	1135103

Description Jan Grulich 2014-12-17 13:17:52 UTC

Spec URL: https://jgrulich.fedorapeople.org/plasma5/ksysguard.spec
SRPM URL: https://jgrulich.fedorapeople.org/plasma5/ksysguard-5.1.1-1.fc21.src.rpm
Description: Performance monitor daemon
Fedora Account System Username: jgrulich

Comment 1 Rex Dieter 2015-01-04 17:04:48 UTC

naming: ok

1. SHOULD use better project url, suggest:
URL: https://projects.kde.org/projects/kde/workspace/ksysguard


2. license NOT ok, some sources are GPLv2 only so MUST use:
License: GPLv2

sources: ok
3b2e23fc9e758741f26d1edb6120ea3d  ksysguard-5.1.1.tar.xz


3. SHOULD prefer/use
make install/fast DESTDIR=%{buildroot}
over
%make_install 


4. SHOULD verify if scriptlets
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
are needed for special-case kdeinit shlib:
%{_kf5_libdir}/libkdeinit5_ksysguard.so


5. MUST validate included application .desktop file, add
BuildRequires: desktop-file-utils
and
%check
desktop-file-validate %{buildroot}%{_datadir}/applications/ksysguard.desktop

6.  MUST add icon cache scriptlets for included
%{_datadir}/icons/hicolor/*/apps/*.png

7. SHOULD use %find_lang ... --with-kde ... to automatically pick up HTML handbooks

Comment 2 Jan Grulich 2015-01-05 15:20:40 UTC

- Fixed license
- Used make install instead of make_install macro
- Removed unnecessary scriptlets and added scriptlets for icon cache
- Added desktop file validation

Spec URL: https://jgrulich.fedorapeople.org/plasma5/ksysguard.spec
SRPM URL: https://jgrulich.fedorapeople.org/plasma5/ksysguard-5.1.1-2.fc21.src.rpm

Comment 3 Daniel Vrátil 2015-01-16 10:52:54 UTC

Rex, could you please finish the review, since you started with it?

Comment 4 Rex Dieter 2015-01-16 13:56:12 UTC

All MUST blocker items resolved, APPROVED (though consider item 7 not implemented yet afaict).

Comment 5 Jan Grulich 2015-01-16 14:12:02 UTC

New Package SCM Request
=======================
Package Name: ksysguard
Short Description: KDE Process Management application
Upstream URL: https://projects.kde.org/projects/kde/workspace/ksysguard
Owners: group::kde-sig
Branches: f20 f21
InitialCC:

Comment 6 Gwyn Ciesla 2015-01-16 14:50:23 UTC

Git done (by process-git-requests).