Bug 1175471

Just for info:

fleet-0.9.0]$ go2fed ggi | grep Godeps | sed 's/github\.com\/coreos\/fleet\/Godeps\/_workspace\/src\///'
	code.google.com/p/google-api-go-client/googleapi
	github.com/coreos/go-semver/semver
	github.com/coreos/go-systemd/activation
	github.com/coreos/go-systemd/dbus
	github.com/coreos/go-systemd/unit
	github.com/docker/libcontainer/netlink
	github.com/godbus/dbus
	github.com/godbus/dbus/introspect
	github.com/jonboulle/clockwork
	github.com/rakyll/globalconf
	github.com/rakyll/goini
	golang.org/x/crypto/ssh
	golang.org/x/crypto/ssh/agent
	golang.org/x/crypto/ssh/terminal
	golang.org/x/crypto/ssh/testdata

So far github.com/jonboulle/clockwork is not in Fedora, the rest is. I can prepare a review request of github.com/jonboulle/clockwork, what do you think?

(In reply to Jan Chaloupka from comment #1)
> Just for info:
> 
> So far github.com/jonboulle/clockwork is not in Fedora, the rest is. I can
> prepare a review request of github.com/jonboulle/clockwork, what do you
> think?

Yes, that would be great! I'll review it.

Ok, this is something:

* https://peter.fedorapeople.org/fleet.spec
* https://peter.fedorapeople.org/fleet-0.9.0-3.fc21.src.rpm

Not all packages are debundled and some patches are required in order to build against ones available in Fedora/EPEL though.

(In reply to Jan Chaloupka from comment #1)
> Just for info:
...
> 	github.com/jonboulle/clockwork
> 	github.com/rakyll/globalconf
> 	github.com/rakyll/goini
...
> So far github.com/jonboulle/clockwork is not in Fedora, the rest is. I can
> prepare a review request of github.com/jonboulle/clockwork, what do you
> think?

Jan, thanks for the "github.com/jonboulle/clockwork" but unfortunately that's not enough. We need "github.com/rakyll/globalconf" and "github.com/rakyll/goini" as well.

Hi Peter, we don't need do redefine %{gopath} anymore (since golang-1.2.1-3)

s/do/to

Done. Must update the test for deps in Godeps folder. Thanks.

Lokesh, I have assigned those two bugs on you.

Peter, don't hesitate to make a review of them if you have some spare time.

Happy New Year :)

Peter,

github.com/rakyll/globalconf and github.com/rakyll/goini are packaged. Is fleet ready for Fedora? Sorry for being late with the packaging.

Regards
Jan

(In reply to Jan Chaloupka from comment #9)
> Peter,
> 
> github.com/rakyll/globalconf and github.com/rakyll/goini are packaged. Is
> fleet ready for Fedora? Sorry for being late with the packaging.
> 
> Regards
> Jan

Jan, wait a second - I'll provide a new package (dependent on these two ones you've just submitted).

Oops! Did I miss something?

http://koji.fedoraproject.org/koji/taskinfo?taskID=8676363
...
DEBUG util.py:366:  Error: No Package found for golang(github.com/coreos/go-systemd)

Ah got that:

* http://pkgs.fedoraproject.org/cgit/golang-github-coreos-go-systemd.git/commit/?id=204f61c

Wait a bit more - I'll update dependencies again.

Ok, here it is:

* https://peter.fedorapeople.org/fleet.spec
* https://peter.fedorapeople.org/fleet-0.9.0-3.fc21.src.rpm

Koji scratchbuild for Rawhide:

* http://koji.fedoraproject.org/koji/taskinfo?taskID=8676520

Created attachment 982295 [details]
spec file modification

Added:
-devel subpackage
-%repo, %provider, ... global variables

Otherwise it looks good.

(In reply to Jan Chaloupka from comment #15)
> Added:
> -devel subpackage
> -%repo, %provider, ... global variables
> 
> Otherwise it looks good.

Updated the package according to your comments (and added one additional patch):

* https://peter.fedorapeople.org/fleet.spec
* https://peter.fedorapeople.org/fleet-0.9.0-4.fc21.src.rpm

Here is a scratchbuild for Rawhide:

* http://koji.fedoraproject.org/koji/taskinfo?taskID=8883895

I forget to add Requires to devel packages for all its BuildRequires. So when you install fleet devel subpackage, you must install all its deps if fleet devel happens to be a buildtime dependency of another package:

Requires:	golang(google.golang.org/api/googleapi)
Requires:	golang(github.com/coreos/go-semver/semver)
Requires:	golang(github.com/coreos/go-systemd/activation)
Requires:	golang(github.com/coreos/go-systemd/dbus)
Requires:	golang(github.com/coreos/go-systemd/unit)
Requires:	golang(github.com/docker/libcontainer/netlink)
Requires:	golang(github.com/godbus/dbus)
Requires:	golang(github.com/jonboulle/clockwork)
Requires:	golang(github.com/rakyll/globalconf)
Requires:	golang(github.com/rakyll/goini)
Requires:	golang(golang.org/x/crypto/ssh)

Please add those below BuildRequires of devel subpackage.

Otherwise spec file complies with Go packaging draft [1]

[1] https://fedoraproject.org/wiki/PackagingDrafts/Go

(In reply to Jan Chaloupka from comment #17)
> I forget to add Requires to devel packages for all its BuildRequires. So
> when you install fleet devel subpackage, you must install all its deps if
> fleet devel happens to be a buildtime dependency of another package:
> 
> Requires:	golang(google.golang.org/api/googleapi)
> Requires:	golang(github.com/coreos/go-semver/semver)
> Requires:	golang(github.com/coreos/go-systemd/activation)
> Requires:	golang(github.com/coreos/go-systemd/dbus)
> Requires:	golang(github.com/coreos/go-systemd/unit)
> Requires:	golang(github.com/docker/libcontainer/netlink)
> Requires:	golang(github.com/godbus/dbus)
> Requires:	golang(github.com/jonboulle/clockwork)
> Requires:	golang(github.com/rakyll/globalconf)
> Requires:	golang(github.com/rakyll/goini)
> Requires:	golang(golang.org/x/crypto/ssh)
> 
> Please add those below BuildRequires of devel subpackage.

Done (didn't raise the %release number though).

* https://peter.fedorapeople.org/fleet.spec
* https://peter.fedorapeople.org/fleet-0.9.0-4.fc21.src.rpm

(In reply to Jan Chaloupka from comment #18)
> Otherwise spec file complies with Go packaging draft [1]
> 
> [1] https://fedoraproject.org/wiki/PackagingDrafts/Go

Thanks!

New Package SCM Request
=======================
Package Name: fleet
Short Description: A distributed init system
Upstream URL: https://github.com/coreos/fleet/
Owners: peter lsm5 jchaloup vbatts
Branches: f21 epel7
InitialCC: golang-sig

Git done (by process-git-requests).