Bug 1175471 - Review Request: fleet - A distributed init system
Summary: Review Request: fleet - A distributed init system
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: NotReady
Depends On: 1175771 1177486 1177487
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-17 19:24 UTC by Peter Lemenkov
Modified: 2015-02-10 13:46 UTC (History)
5 users (show)

Fixed In Version: fleet-0.9.0-4.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-10 13:46:41 UTC
Type: ---
Embargoed:
jchaloup: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
spec file modification (6.58 KB, patch)
2015-01-21 11:43 UTC, Jan Chaloupka
no flags Details | Diff

Description Peter Lemenkov 2014-12-17 19:24:11 UTC
Spec URL: https://peter.fedorapeople.org/fleet.spec
SRPM URL: https://peter.fedorapeople.org/fleet-0.9.0-2.el7.centos.src.rpm
Description: A distributed init system.
Fedora Account System Username: peter

Comment 1 Jan Chaloupka 2014-12-18 10:44:23 UTC
Just for info:

fleet-0.9.0]$ go2fed ggi | grep Godeps | sed 's/github\.com\/coreos\/fleet\/Godeps\/_workspace\/src\///'
	code.google.com/p/google-api-go-client/googleapi
	github.com/coreos/go-semver/semver
	github.com/coreos/go-systemd/activation
	github.com/coreos/go-systemd/dbus
	github.com/coreos/go-systemd/unit
	github.com/docker/libcontainer/netlink
	github.com/godbus/dbus
	github.com/godbus/dbus/introspect
	github.com/jonboulle/clockwork
	github.com/rakyll/globalconf
	github.com/rakyll/goini
	golang.org/x/crypto/ssh
	golang.org/x/crypto/ssh/agent
	golang.org/x/crypto/ssh/terminal
	golang.org/x/crypto/ssh/testdata

So far github.com/jonboulle/clockwork is not in Fedora, the rest is. I can prepare a review request of github.com/jonboulle/clockwork, what do you think?

Comment 2 Peter Lemenkov 2014-12-18 11:16:09 UTC
(In reply to Jan Chaloupka from comment #1)
> Just for info:
> 
> So far github.com/jonboulle/clockwork is not in Fedora, the rest is. I can
> prepare a review request of github.com/jonboulle/clockwork, what do you
> think?

Yes, that would be great! I'll review it.

Comment 3 Peter Lemenkov 2014-12-18 12:27:02 UTC
Ok, this is something:

* https://peter.fedorapeople.org/fleet.spec
* https://peter.fedorapeople.org/fleet-0.9.0-3.fc21.src.rpm

Not all packages are debundled and some patches are required in order to build against ones available in Fedora/EPEL though.

Comment 4 Peter Lemenkov 2014-12-26 13:34:00 UTC
(In reply to Jan Chaloupka from comment #1)
> Just for info:
...
> 	github.com/jonboulle/clockwork
> 	github.com/rakyll/globalconf
> 	github.com/rakyll/goini
...
> So far github.com/jonboulle/clockwork is not in Fedora, the rest is. I can
> prepare a review request of github.com/jonboulle/clockwork, what do you
> think?

Jan, thanks for the "github.com/jonboulle/clockwork" but unfortunately that's not enough. We need "github.com/rakyll/globalconf" and "github.com/rakyll/goini" as well.

Comment 5 Lokesh Mandvekar 2014-12-27 18:56:25 UTC
Hi Peter, we don't need do redefine %{gopath} anymore (since golang-1.2.1-3)

Comment 6 Lokesh Mandvekar 2014-12-27 18:56:46 UTC
s/do/to

Comment 7 Jan Chaloupka 2014-12-27 22:40:30 UTC
Done. Must update the test for deps in Godeps folder. Thanks.

Comment 8 Jan Chaloupka 2014-12-27 22:43:01 UTC
Lokesh, I have assigned those two bugs on you.

Peter, don't hesitate to make a review of them if you have some spare time.

Happy New Year :)

Comment 9 Jan Chaloupka 2015-01-20 16:07:18 UTC
Peter,

github.com/rakyll/globalconf and github.com/rakyll/goini are packaged. Is fleet ready for Fedora? Sorry for being late with the packaging.

Regards
Jan

Comment 10 Peter Lemenkov 2015-01-20 16:55:41 UTC
(In reply to Jan Chaloupka from comment #9)
> Peter,
> 
> github.com/rakyll/globalconf and github.com/rakyll/goini are packaged. Is
> fleet ready for Fedora? Sorry for being late with the packaging.
> 
> Regards
> Jan

Jan, wait a second - I'll provide a new package (dependent on these two ones you've just submitted).

Comment 11 Peter Lemenkov 2015-01-20 17:01:07 UTC
Oops! Did I miss something?

http://koji.fedoraproject.org/koji/taskinfo?taskID=8676363
...
DEBUG util.py:366:  Error: No Package found for golang(github.com/coreos/go-systemd)

Comment 12 Peter Lemenkov 2015-01-20 17:08:30 UTC
Ah got that:

* http://pkgs.fedoraproject.org/cgit/golang-github-coreos-go-systemd.git/commit/?id=204f61c

Wait a bit more - I'll update dependencies again.

Comment 14 Jan Chaloupka 2015-01-21 11:43:51 UTC
Created attachment 982295 [details]
spec file modification

Comment 15 Jan Chaloupka 2015-01-21 11:44:45 UTC
Added:
-devel subpackage
-%repo, %provider, ... global variables

Otherwise it looks good.

Comment 16 Peter Lemenkov 2015-02-10 11:53:54 UTC
(In reply to Jan Chaloupka from comment #15)
> Added:
> -devel subpackage
> -%repo, %provider, ... global variables
> 
> Otherwise it looks good.

Updated the package according to your comments (and added one additional patch):

* https://peter.fedorapeople.org/fleet.spec
* https://peter.fedorapeople.org/fleet-0.9.0-4.fc21.src.rpm

Here is a scratchbuild for Rawhide:

* http://koji.fedoraproject.org/koji/taskinfo?taskID=8883895

Comment 17 Jan Chaloupka 2015-02-10 12:00:13 UTC
I forget to add Requires to devel packages for all its BuildRequires. So when you install fleet devel subpackage, you must install all its deps if fleet devel happens to be a buildtime dependency of another package:

Requires:	golang(google.golang.org/api/googleapi)
Requires:	golang(github.com/coreos/go-semver/semver)
Requires:	golang(github.com/coreos/go-systemd/activation)
Requires:	golang(github.com/coreos/go-systemd/dbus)
Requires:	golang(github.com/coreos/go-systemd/unit)
Requires:	golang(github.com/docker/libcontainer/netlink)
Requires:	golang(github.com/godbus/dbus)
Requires:	golang(github.com/jonboulle/clockwork)
Requires:	golang(github.com/rakyll/globalconf)
Requires:	golang(github.com/rakyll/goini)
Requires:	golang(golang.org/x/crypto/ssh)

Please add those below BuildRequires of devel subpackage.

Comment 18 Jan Chaloupka 2015-02-10 12:01:59 UTC
Otherwise spec file complies with Go packaging draft [1]

[1] https://fedoraproject.org/wiki/PackagingDrafts/Go

Comment 19 Peter Lemenkov 2015-02-10 12:10:01 UTC
(In reply to Jan Chaloupka from comment #17)
> I forget to add Requires to devel packages for all its BuildRequires. So
> when you install fleet devel subpackage, you must install all its deps if
> fleet devel happens to be a buildtime dependency of another package:
> 
> Requires:	golang(google.golang.org/api/googleapi)
> Requires:	golang(github.com/coreos/go-semver/semver)
> Requires:	golang(github.com/coreos/go-systemd/activation)
> Requires:	golang(github.com/coreos/go-systemd/dbus)
> Requires:	golang(github.com/coreos/go-systemd/unit)
> Requires:	golang(github.com/docker/libcontainer/netlink)
> Requires:	golang(github.com/godbus/dbus)
> Requires:	golang(github.com/jonboulle/clockwork)
> Requires:	golang(github.com/rakyll/globalconf)
> Requires:	golang(github.com/rakyll/goini)
> Requires:	golang(golang.org/x/crypto/ssh)
> 
> Please add those below BuildRequires of devel subpackage.

Done (didn't raise the %release number though).

* https://peter.fedorapeople.org/fleet.spec
* https://peter.fedorapeople.org/fleet-0.9.0-4.fc21.src.rpm

(In reply to Jan Chaloupka from comment #18)
> Otherwise spec file complies with Go packaging draft [1]
> 
> [1] https://fedoraproject.org/wiki/PackagingDrafts/Go

Thanks!

New Package SCM Request
=======================
Package Name: fleet
Short Description: A distributed init system
Upstream URL: https://github.com/coreos/fleet/
Owners: peter lsm5 jchaloup vbatts
Branches: f21 epel7
InitialCC: golang-sig

Comment 20 Gwyn Ciesla 2015-02-10 13:17:16 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.