Bug 1175771
| Summary: | Review Request: golang-github-jonboulle-clockwork - A fake clock for golang | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Chaloupka <jchaloup> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | golang-github-jonboulle-clockwork-0-0.1.git3f831b6.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-01-03 19:02:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1175471 | ||
|
Description
Jan Chaloupka
2014-12-18 14:41:32 UTC
Upstream: https://github.com/jonboulle/clockwork I'll review it. REVIEW:
[+] rpmlint is silent (or produces only messages which can be safely ignored:
Auriga ~/rpmbuild/SPECS: rpmlint ../RPMS/noarch/golang-github-jonboulle-clockwork-devel-0-0.1.git3f831b6.fc21.noarch.rpm ../SRPMS/golang-github-jonboulle-clockwork-0-0.1.git3f831b6.fc21.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Auriga ~/rpmbuild/SPECS:
[+] The package is named according to the Package Naming Guidelines.
[+] The spec file name matches the base package %{name}, in the format %{name}.spec.
[+] The package meets the Packaging Guidelines.
[+] The package is licensed with a Fedora approved license and meets the Licensing Guidelines (Apache Software License 2.0).
[+] The License field in the package spec file matches the actual license.
[+] The file, containing the text of the license(s) for the package, is included in %doc.
[+] The spec file is written in American English.
[+] The spec file for the package is legible.
[+] The sources used to build the package matches the upstream source, as provided in the spec URL.
Auriga ~/rpmbuild/SOURCES: sha256sum clockwork-3f831b6.tar.gz*
856c8f30fa3634616447eae03cef6d2f04be7f49f474bc4bb7298721c5ea1beb clockwork-3f831b6.tar.gz
856c8f30fa3634616447eae03cef6d2f04be7f49f474bc4bb7298721c5ea1beb clockwork-3f831b6.tar.gz.1
Auriga ~/rpmbuild/SOURCES:
[+] The package successfully compiles and builds into binary rpms.
[+] All build dependencies aree listed in BuildRequires.
[0] No need to handle locales.
[0] The package does not contain any shared library files.
[+] Packages does not bundle copies of system libraries.
[+] The package isn't designed to be relocatable.
[+] The package owns all directories that it creates.
[+] The package does not list a file more than once in the spec file's %files listings.
[+] Permissions on files are set properly.
[+] The package consistently uses macros.
[+] The package contains code, or permissible content.
[0] No large documentation files.
[+] Anything, the package includes as %doc, does not affect the runtime of the application.
[0] No static libraries.
[+] Development files stored in a -devel package.
[+] The package does not contain any .la libtool archives.
[0] Not a GUI application.
[+] The package does not own files or directories already owned by other packages.
[+] All filenames in rpm packages are valid UTF-8.
I can't find any issues, so this package is
APPROVED.
New Package SCM Request ======================= Package Name: golang-github-jonboulle-clockwork Short Description: A fake clock for golang Upstream URL: https://github.com/jonboulle/clockwork Owners: jchaloup lsm5 Branches: f21 f20 f19 el6 InitialCC: golang-sig Git done (by process-git-requests). golang-github-jonboulle-clockwork-0-0.1.git3f831b6.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-jonboulle-clockwork-0-0.1.git3f831b6.fc20 golang-github-jonboulle-clockwork-0-0.1.git3f831b6.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-jonboulle-clockwork-0-0.1.git3f831b6.fc21 golang-github-jonboulle-clockwork-0-0.1.git3f831b6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-jonboulle-clockwork-0-0.1.git3f831b6.el6 golang-github-jonboulle-clockwork-0-0.1.git3f831b6.el6 has been pushed to the Fedora EPEL 6 testing repository. golang-github-jonboulle-clockwork-0-0.1.git3f831b6.fc21 has been pushed to the Fedora 21 stable repository. golang-github-jonboulle-clockwork-0-0.1.git3f831b6.fc20 has been pushed to the Fedora 20 stable repository. golang-github-jonboulle-clockwork-0-0.1.git3f831b6.el6 has been pushed to the Fedora EPEL 6 stable repository. |