| Summary: | Review Request: nodejs-html-minifier - HTML minifier with lint-like capabilities | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Piotr Popieluch <piotr1212> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
petersen: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-html-minifier-0.6.9-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-27 00:52:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 1170802, 1171350 | ||
| Bug Blocks: | 1176445, 1177702 | ||
|
Description
Piotr Popieluch
2014-12-18 19:51:11 UTC
Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-html-minifier.noarch: W: only-non-binary-in-usr-lib nodejs-html-minifier.noarch: W: dangling-symlink /usr/lib/node_modules/html-minifier/node_modules/change-case /usr/lib/node_modules/change-case nodejs-html-minifier.noarch: W: dangling-symlink /usr/lib/node_modules/html-minifier/node_modules/clean-css /usr/lib/node_modules/clean-css nodejs-html-minifier.noarch: W: dangling-symlink /usr/lib/node_modules/html-minifier/node_modules/cli /usr/lib/node_modules/cli nodejs-html-minifier.noarch: W: dangling-symlink /usr/lib/node_modules/html-minifier/node_modules/uglify-js /usr/lib/node_modules/uglify-js@2 nodejs-html-minifier.noarch: W: dangling-symlink /usr/lib/node_modules/html-minifier/node_modules/relateurl /usr/lib/node_modules/relateurl nodejs-html-minifier.src: W: strange-permission nodejs-html-minifier-dl-tests.sh 0755L nodejs-html-minifier.src: W: invalid-url Source1: nodejs-html-minifier-tests-v0.6.9.tar.bz2 2 packages and 0 specfiles checked; 0 errors, 8 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 5e58d4e5bb59ed6b24da67b822f30af8f016d3d19331981c1aea8f9349a7047b upstream tarball: 5e58d4e5bb59ed6b24da67b822f30af8f016d3d19331981c1aea8f9349a7047b + License is "MIT" and included in its own LICENSE file. + follows nodejs packaging guidelines. Suggestions: 1) Group tag is optional and can be removed. APPROVED. Thank you for review. Group tag removed. Could you please check https://bugzilla.redhat.com/show_bug.cgi?id=1170802 as it blocks this package? New Package SCM Request ======================= Package Name: nodejs-html-minifier Short Description: HTML minifier with lint-like capabilities Upstream URL: https://kangax.github.io/html-minifier/ Owners: piotrp Branches: f20 f21 el6 epel7 Git done (by process-git-requests). nodejs-html-minifier-0.6.9-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-html-minifier-0.6.9-1.fc20 nodejs-html-minifier-0.6.9-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-html-minifier-0.6.9-1.fc21 nodejs-html-minifier-0.6.9-1.fc21 has been pushed to the Fedora 21 testing repository. package built, closing. nodejs-html-minifier-0.6.9-1.fc21 has been pushed to the Fedora 21 stable repository. nodejs-html-minifier-0.6.9-1.fc20 has been pushed to the Fedora 20 stable repository. nodejs-html-minifier-0.6.9-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-html-minifier-0.6.9-1.el7 nodejs-html-minifier-0.6.9-1.el7 has been pushed to the Fedora EPEL 7 stable repository. |