Bug 1176881

Summary:	Review Request: nodejs-bl - A Node.js Buffer list collector, reader and streamer
Product:	[Fedora] Fedora	Reporter:	Piotr Popieluch <piotr1212>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	nodejs-bl-0.9.3-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-12-31 18:18:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1176880
Bug Blocks:	1176808, 1176882

Description Piotr Popieluch 2014-12-23 14:38:59 UTC

Spec URL: https://piotrp.fedorapeople.org/nodejs-bl.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-bl-0.9.3-1.fc21.src.rpm
Description: 
bl is a storage object for collections of Node Buffers, exposing them with the 
main Buffer readable API. Also works as a duplex stream so you can collect
buffers from a stream that emits them and emit buffers to a stream that
consumes them!
Fedora Account System Username: piotrp

Comment 1 Parag AN(पराग) 2014-12-23 16:53:24 UTC

Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-bl.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-bl.noarch: W: only-non-binary-in-usr-lib
nodejs-bl.noarch: W: dangling-symlink /usr/lib/node_modules/bl/node_modules/readable-stream /usr/lib/node_modules/readable-stream
nodejs-bl.src: W: spelling-error Summary(en_US) js -> dis, ks, j
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball:  5170771a8b7ce209aeceabc8ce4c4ab0d3b11ce683151e0ff5ceb70a93716620
upstream tarball:   5170771a8b7ce209aeceabc8ce4c4ab0d3b11ce683151e0ff5ceb70a93716620

+ License is "MIT" and included in its own LICENSE.md file.

+ follows nodejs packaging guidelines.

APPROVED.

Comment 2 Piotr Popieluch 2014-12-24 10:32:56 UTC

New Package SCM Request
=======================
Package Name: nodejs-bl
Short Description: A Node.js Buffer list collector, reader and streamer
Upstream URL: https://github.com/rvagg/bl
Owners: piotrp
Branches: f20 f21 el6 epel7

Comment 3 Gwyn Ciesla 2014-12-24 11:23:33 UTC

Git done (by process-git-requests).

Comment 4 Fedora Update System 2014-12-26 21:13:12 UTC

nodejs-bl-0.9.3-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-bl-0.9.3-1.el7

Comment 5 Fedora Update System 2014-12-26 22:04:11 UTC

nodejs-bl-0.9.3-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-bl-0.9.3-1.fc21

Comment 6 Fedora Update System 2014-12-26 22:05:35 UTC

nodejs-bl-0.9.3-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-bl-0.9.3-1.fc20

Comment 7 Fedora Update System 2014-12-28 20:42:58 UTC

nodejs-bl-0.9.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 8 Piotr Popieluch 2014-12-31 18:18:15 UTC

package built, closing.

Comment 9 Fedora Update System 2015-01-06 06:06:01 UTC

nodejs-bl-0.9.3-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 10 Fedora Update System 2015-01-06 06:08:26 UTC

nodejs-bl-0.9.3-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 11 Fedora Update System 2015-01-24 18:42:58 UTC

nodejs-bl-0.9.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository.