Bug 1176882 - Review Request: nodejs-tar-stream - A streaming tar parser and generator
Summary: Review Request: nodejs-tar-stream - A streaming tar parser and generator
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1176809 1176881
Blocks: 1177550
TreeView+ depends on / blocked
 
Reported: 2014-12-23 14:42 UTC by Piotr Popieluch
Modified: 2015-01-19 01:32 UTC (History)
2 users (show)

Fixed In Version: nodejs-tar-stream-1.1.1-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-31 18:17:51 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Piotr Popieluch 2014-12-23 14:42:27 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-tar-stream.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-tar-stream-1.1.1-1.fc21.src.rpm
Description: 
tar-stream is a streaming tar parser and generator and nothing else. It is
streams2 and operates purely using streams which means you can easily
extract/parse tarballs without ever hitting the file system.

Fedora Account System Username: piotrp

Comment 1 Parag AN(पराग) 2014-12-23 16:57:42 UTC
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-tar-stream.noarch: W: only-non-binary-in-usr-lib
nodejs-tar-stream.noarch: W: dangling-symlink /usr/lib/node_modules/tar-stream/node_modules/xtend /usr/lib/node_modules/xtend
nodejs-tar-stream.noarch: W: dangling-symlink /usr/lib/node_modules/tar-stream/node_modules/readable-stream /usr/lib/node_modules/readable-stream
nodejs-tar-stream.noarch: W: dangling-symlink /usr/lib/node_modules/tar-stream/node_modules/end-of-stream /usr/lib/node_modules/end-of-stream
nodejs-tar-stream.noarch: W: dangling-symlink /usr/lib/node_modules/tar-stream/node_modules/bl /usr/lib/node_modules/bl
nodejs-tar-stream.src: W: strange-permission nodejs-tar-stream-dl-tests.sh 0755L
nodejs-tar-stream.src: W: invalid-url Source1: nodejs-tar-stream-tests-v1.1.1.tar.bz2
2 packages and 0 specfiles checked; 0 errors, 7 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball:  d048774bddd96320151f7924bb51451aed6fe0b583b7e1ec050f56cd14945fb4
upstream tarball:   d048774bddd96320151f7924bb51451aed6fe0b583b7e1ec050f56cd14945fb4

+ License is "MIT" and included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Fix the Source1 file name

APPROVED.

Comment 2 Piotr Popieluch 2014-12-24 10:33:21 UTC
New Package SCM Request
=======================
Package Name: nodejs-tar-stream
Short Description: A streaming tar parser and generator
Upstream URL: https://github.com/mafintosh/tar-stream
Owners: piotrp
Branches: f20 f21 el6 epel7

Comment 3 Gwyn Ciesla 2014-12-24 11:25:25 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2014-12-31 18:07:55 UTC
nodejs-tar-stream-1.1.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-tar-stream-1.1.1-1.fc21

Comment 5 Piotr Popieluch 2014-12-31 18:17:51 UTC
package built in f21. 
f20 epel7 builds fail, too old version of nodejs-deep-equal. closing report

Comment 6 Fedora Update System 2015-01-19 01:32:35 UTC
nodejs-tar-stream-1.1.1-1.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.