Bug 1177486
| Summary: | Review Request: golang-github-glacjay-goini - INI file parser in go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Chaloupka <jchaloup> |
| Component: | Package Review | Assignee: | Lokesh Mandvekar <lsm5> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lemenkov, package-review |
| Target Milestone: | --- | Flags: | lsm5:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | golang-github-glacjay-goini-0-0.1.git5261baf.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-01-30 04:35:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1175471, 1177487 | ||
|
Description
Jan Chaloupka
2014-12-27 22:30:00 UTC
Specfile looks good except that it doesn't have any license so far like you noted. It's a fork of glacjay/goini which uses the MIT license, so maybe we should contact rakyll or perhaps package glacjay/goini and have it provide rakyll/goini (if that works at all) (In reply to Lokesh Mandvekar from comment #1) > Specfile looks good except that it doesn't have any license so far like you > noted. It's a fork of glacjay/goini which uses the MIT license, so maybe we > should contact rakyll or perhaps package glacjay/goini and have it provide > rakyll/goini (if that works at all) I wonder maybe it's better for us to stick with the original repository rather than with the personal fork? Created a pull request for a licence: https://github.com/rakyll/goini/pull/2 The original is different from the forked. It can work for fleet, it does not have to. Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-glacjay-goini/golang-github-glacjay-goini.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-glacjay-goini/golang-github-glacjay-goini-0-0.1.git5261baf.fc20.src.rpm Description: INI file parser in go Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8602896 $ rpmlint golang-github-glacjay-goini-0-0.1.git5261baf.fc20.src.rpm golang-github-glacjay-goini-devel-0-0.1.git5261baf.fc20.noarch.rpm golang-github-glacjay-goini.spec golang-github-glacjay-goini.src:62: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 62) golang-github-glacjay-goini-devel.noarch: E: zero-length /usr/share/gocode/src/github.com/glacjay/goini/empty.ini golang-github-glacjay-goini.spec:62: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 62) 2 packages and 1 specfiles checked; 1 errors, 2 warnings. Notes: empty.ini is used in tests => ignore error. rakyll-goini is going to be provided as another tarball (older version of glacjay/goini). Upstream: https://github.com/glacjay/goini Spec file looks good as per golang packaging draft. - Upstream license is correct - only sources installed for now Package approved. New Package SCM Request ======================= Package Name: golang-github-glacjay-goini Short Description: INI file parser in go Upstream URL: https://github.com/glacjay/goini Owners: jchaloup lsm5 Branches: f21 f20 f19 el6 InitialCC: golang-sig Git done (by process-git-requests). f19 no longer accepting new branches. golang-github-glacjay-goini-0-0.1.git5261baf.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-glacjay-goini-0-0.1.git5261baf.fc20 golang-github-glacjay-goini-0-0.1.git5261baf.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-glacjay-goini-0-0.1.git5261baf.fc21 golang-github-glacjay-goini-0-0.1.git5261baf.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-glacjay-goini-0-0.1.git5261baf.el6 golang-github-glacjay-goini-0-0.1.git5261baf.fc20 has been pushed to the Fedora 20 testing repository. golang-github-glacjay-goini-0-0.1.git5261baf.fc20 has been pushed to the Fedora 20 stable repository. golang-github-glacjay-goini-0-0.1.git5261baf.fc21 has been pushed to the Fedora 21 stable repository. golang-github-glacjay-goini-0-0.1.git5261baf.el6 has been pushed to the Fedora EPEL 6 stable repository. |