Bug 1178213

Summary:	Pressing Cancel button on Service Dialog Edit screen displays incorrect flash Message
Product:	Red Hat CloudForms Management Engine	Reporter:	Dan Clarizio <dclarizi>
Component:	UI - OPS	Assignee:	Greg Piatigorski <gpiatigo>
Status:	CLOSED ERRATA	QA Contact:	Aziza Karol <akarol>
Severity:	low	Docs Contact:
Priority:	medium
Version:	5.3.0	CC:	akarol, jhardy, obarenbo, xlecauch
Target Milestone:	GA
Target Release:	5.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.5.0.1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-08 13:01:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Clarizio 2015-01-02 21:52:09 UTC

Description of problem:
Pressing Cancel button on Service Dialog Edit screen gets this incorrect flash message displayed: "Add of new Dialog was cancelled by the user"

Version-Release number of selected component (if applicable):
5.3

Expected results:
Should display a flash message that edit was cancelled.

Comment 2 CFME Bot 2015-05-22 19:05:58 UTC

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/a2e3c46ceeab53a94f06344c77079a5d24a4b113

commit a2e3c46ceeab53a94f06344c77079a5d24a4b113
Author:     Greg Piatigorski <gpiatigo>
AuthorDate: Wed May 20 13:45:03 2015 -0700
Commit:     Greg Piatigorski <gpiatigo>
CommitDate: Fri May 22 11:33:50 2015 -0700

    Flash message fixed for Service Dialogs Edit
    
    Corrected flash message text to Edit... when canceling out of Service Dialog Edit mode.
    Optimized code to avoid database access when formatting flash message text
    Refactored code for better readability
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1178213

 .../controllers/miq_ae_customization_controller/dialogs.rb    | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Comment 3 Greg Piatigorski 2015-05-22 19:14:40 UTC

Code fix posted.

Comment 4 Aziza Karol 2015-10-01 12:14:05 UTC

Verified in 5.5.0.3-alpha1.2.20150929172214_2eda7b4

Comment 6 errata-xmlrpc 2015-12-08 13:01:59 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551