Bug 1178213 - Pressing Cancel button on Service Dialog Edit screen displays incorrect flash Message
Summary: Pressing Cancel button on Service Dialog Edit screen displays incorrect flash...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.3.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: GA
: 5.5.0
Assignee: Greg Piatigorski
QA Contact: Aziza Karol
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-02 21:52 UTC by Dan Clarizio
Modified: 2015-12-08 13:01 UTC (History)
4 users (show)

Fixed In Version: 5.5.0.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-08 13:01:59 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:2551 0 normal SHIPPED_LIVE Moderate: CFME 5.5.0 bug fixes and enhancement update 2015-12-08 17:58:09 UTC

Description Dan Clarizio 2015-01-02 21:52:09 UTC
Description of problem:
Pressing Cancel button on Service Dialog Edit screen gets this incorrect flash message displayed: "Add of new Dialog was cancelled by the user"

Version-Release number of selected component (if applicable):
5.3

Expected results:
Should display a flash message that edit was cancelled.

Comment 2 CFME Bot 2015-05-22 19:05:58 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/a2e3c46ceeab53a94f06344c77079a5d24a4b113

commit a2e3c46ceeab53a94f06344c77079a5d24a4b113
Author:     Greg Piatigorski <gpiatigo>
AuthorDate: Wed May 20 13:45:03 2015 -0700
Commit:     Greg Piatigorski <gpiatigo>
CommitDate: Fri May 22 11:33:50 2015 -0700

    Flash message fixed for Service Dialogs Edit
    
    Corrected flash message text to Edit... when canceling out of Service Dialog Edit mode.
    Optimized code to avoid database access when formatting flash message text
    Refactored code for better readability
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1178213

 .../controllers/miq_ae_customization_controller/dialogs.rb    | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Comment 3 Greg Piatigorski 2015-05-22 19:14:40 UTC
Code fix posted.

Comment 4 Aziza Karol 2015-10-01 12:14:05 UTC
Verified in 5.5.0.3-alpha1.2.20150929172214_2eda7b4

Comment 6 errata-xmlrpc 2015-12-08 13:01:59 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551


Note You need to log in before you can comment on or make changes to this bug.