Bug 1178687
| Summary: | Review Request: python-glob2 - Glob module recursive wildcards support | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Julien Enselme <jujens> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-glob2-0.4.1-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-04 07:56:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Julien Enselme
2015-01-05 10:03:49 UTC
Looks good. I think you can simplify the spec by not creating a separate build dir for python3. All that the "build" does is copy the .py files and generate .py[co], and .py[co] files for Python 2 and 3 are in different directories, so there's no conflict. There's no license file. Please ping upstream and add a comment in the spec file. $ rpmlint python-glob2 python-glob2.noarch: W: spelling-error Summary(en_US) wildcards -> wild cards, wild-cards, wildcatters python-glob2.noarch: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint python3-glob2 python3-glob2.noarch: W: spelling-error Summary(en_US) wildcards -> wild cards, wild-cards, wildcatters python3-glob2.noarch: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Yes, package is OK as is, even before the cleanups from #c1. Package is APPROVED. The license was added upstream some time ago: https://github.com/miracle2k/python-glob2/blob/master/LICENSE It is just not included in any release yet. > I think you can simplify the spec by not creating a separate build dir for python3. All that the "build" does is copy the .py files and generate .py[co], and .py[co] files for Python 2 and 3 are in different directories, so there's no conflict. Maybe, but I am used to this method now and it is what I saw in the wiki: https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file. Thanks for your review! New Package SCM Request ======================= Package Name: python-glob2 Short Description: Glob module recursive wildcards support Upstream URL: https://pypi.python.org/pypi/glob2 Owners: jujens Branches: fc20 fc21 Git done (by process-git-requests). python-glob2-0.4.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-glob2-0.4.1-2.fc20 python-glob2-0.4.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-glob2-0.4.1-2.fc21 Package python-glob2-0.4.1-2.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-glob2-0.4.1-2.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-1221/python-glob2-0.4.1-2.fc21 then log in and leave karma (feedback). python-glob2-0.4.1-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. python-glob2-0.4.1-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |