Bug 1178687 - Review Request: python-glob2 - Glob module recursive wildcards support
Summary: Review Request: python-glob2 - Glob module recursive wildcards support
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-05 10:03 UTC by Julien Enselme
Modified: 2015-02-04 08:03 UTC (History)
2 users (show)

Fixed In Version: python-glob2-0.4.1-2.fc21
Clone Of:
Environment:
Last Closed: 2015-02-04 07:56:15 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Julien Enselme 2015-01-05 10:03:49 UTC
Spec URL: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-glob2.spec
SRPM URL: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-glob2-0.4.1-1.fc21.src.rpm
Description:
Version of the glob module that can capture patterns and supports recursive
wildcards.
Fedora Account System Username: jujens

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-01-24 17:32:47 UTC
Looks good.

I think you can simplify the spec by not creating a separate build dir for python3. All that the "build" does is copy the .py files and generate .py[co], and .py[co] files for Python 2 and 3 are in different directories, so there's no conflict.

There's no license file. Please ping upstream and add a comment in the spec file.

Comment 2 Zbigniew Jędrzejewski-Szmek 2015-01-24 17:36:03 UTC
$ rpmlint python-glob2
python-glob2.noarch: W: spelling-error Summary(en_US) wildcards -> wild cards, wild-cards, wildcatters
python-glob2.noarch: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint python3-glob2
python3-glob2.noarch: W: spelling-error Summary(en_US) wildcards -> wild cards, wild-cards, wildcatters
python3-glob2.noarch: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Yes, package is OK as is, even before the cleanups from #c1.
Package is APPROVED.

Comment 3 Julien Enselme 2015-01-25 16:45:23 UTC
The license was added upstream some time ago: https://github.com/miracle2k/python-glob2/blob/master/LICENSE It is just not included in any release yet.

> I think you can simplify the spec by not creating a separate build dir for python3. All that the "build" does is copy the .py files and generate .py[co], and .py[co] files for Python 2 and 3 are in different directories, so there's no conflict.
Maybe, but I am used to this method now and it is what I saw in the wiki: https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file.

Thanks for your review!

Comment 4 Julien Enselme 2015-01-25 16:47:05 UTC
New Package SCM Request
=======================
Package Name: python-glob2
Short Description: Glob module recursive wildcards support
Upstream URL: https://pypi.python.org/pypi/glob2
Owners: jujens
Branches: fc20 fc21

Comment 5 Gwyn Ciesla 2015-01-25 21:40:19 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2015-01-26 16:45:01 UTC
python-glob2-0.4.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-glob2-0.4.1-2.fc20

Comment 7 Fedora Update System 2015-01-26 16:45:07 UTC
python-glob2-0.4.1-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-glob2-0.4.1-2.fc21

Comment 8 Fedora Update System 2015-01-27 03:00:42 UTC
Package python-glob2-0.4.1-2.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-glob2-0.4.1-2.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-1221/python-glob2-0.4.1-2.fc21
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2015-02-04 07:56:15 UTC
python-glob2-0.4.1-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2015-02-04 08:03:39 UTC
python-glob2-0.4.1-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.