Bug 1178940
| Summary: | Review Request: libqhyccd - Library to control QHY CCD devices | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christian Dersch <lupinix.fedora> |
| Component: | Package Review | Assignee: | Wolfgang Ulbrich <raveit65.sun> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, sergio.pasra, tcallawa |
| Target Milestone: | --- | Flags: | raveit65.sun:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-04 13:37:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1159999 | ||
|
Description
Christian Dersch
2015-01-05 17:14:50 UTC
Firmware license is okay. Lifting FE-Legal. Thank you for checking the license Tom! Koji builds: Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8543609 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=8543622 F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=8543616 Patch for library path submitted upstream: http://sourceforge.net/p/indi/bugs/58/ Missing GPLv2 copy and wrong FSF address: http://sourceforge.net/p/indi/bugs/59/ there are some rpmlint warning which can be fixed. libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_videostab.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_ts.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_superres.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_stitching.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_photo.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_ocl.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_legacy.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_contrib.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_calib3d.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_video.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_objdetect.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_ml.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_features2d.so.2.4 https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency source macro doesn't match. Source0: %{name}-%{version}.svn%{svn}.tar.xz libqhyccd.src: W: invalid-url Source0: libqhyccd-0.1.svn1920.tar.xz If there isn't a valid link to svn source at sourceforge, pls upload it to your fedora people account and mentioned it in spec file. I'm not shure how we handle the missing COPYING file. The rest looks good. another one. qhy-firmware.noarch: W: only-non-binary-in-usr-lib can you move this to /usr/share ? Forget about my last comment. Firmware and udev folders are under /usr/share :) (In reply to Wolfgang Ulbrich from comment #5) > Forget about my last comment. > Firmware and udev folders are under /usr/share :) typo, i meant Firmware and udev folders are under /usr/lib Ups, sorry for the noise. Wolfgang, could you put fedora-review to "?" ? Closed for now, I think it is wise to wait some more time due to big changes upstream. |