Spec URL: https://lupinix.fedorapeople.org/review/libqhyccd/libqhyccd.spec SRPM URL: https://lupinix.fedorapeople.org/review/libqhyccd/libqhyccd-0.1-0.1.20150105svn1920.fc21.src.rpm Description: Library to control QHY CCD devices Fedora Account System Username: lupinix Known issues: * Firmware uses a nonfree license, I will add the review to legal tracker. License looks similar to linux-firmware licenses. We have to wait for legal approvement. * Most source files use wrong FSF address, reported upstream * No copy of GPLv2 in upstream repo, reported upstream Thanks for review in advance!
Firmware license is okay. Lifting FE-Legal.
Thank you for checking the license Tom! Koji builds: Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8543609 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=8543622 F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=8543616 Patch for library path submitted upstream: http://sourceforge.net/p/indi/bugs/58/ Missing GPLv2 copy and wrong FSF address: http://sourceforge.net/p/indi/bugs/59/
there are some rpmlint warning which can be fixed. libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_videostab.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_ts.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_superres.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_stitching.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_photo.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_ocl.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_legacy.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_contrib.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_calib3d.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_video.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_objdetect.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_ml.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_features2d.so.2.4 https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency source macro doesn't match. Source0: %{name}-%{version}.svn%{svn}.tar.xz libqhyccd.src: W: invalid-url Source0: libqhyccd-0.1.svn1920.tar.xz If there isn't a valid link to svn source at sourceforge, pls upload it to your fedora people account and mentioned it in spec file. I'm not shure how we handle the missing COPYING file. The rest looks good.
another one. qhy-firmware.noarch: W: only-non-binary-in-usr-lib can you move this to /usr/share ?
Forget about my last comment. Firmware and udev folders are under /usr/share :)
(In reply to Wolfgang Ulbrich from comment #5) > Forget about my last comment. > Firmware and udev folders are under /usr/share :) typo, i meant Firmware and udev folders are under /usr/lib
Ups, sorry for the noise. Wolfgang, could you put fedora-review to "?" ?
Closed for now, I think it is wise to wait some more time due to big changes upstream.