Bug 118017

Summary:	system-config-samba fails to open edit users dialog, delete user option effected
Product:	[Fedora] Fedora	Reporter:	Andrew Farris <lordmorgul>
Component:	system-config-samba	Assignee:	Brent Fox <bfox>
Status:	CLOSED RAWHIDE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	lordmorgul
Target Milestone:	---
Target Release:	---
Hardware:	i686
OS:	Linux
URL:	http://www.andrewfarris.com/fedora/strace.system-config-samba.10march.txt
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2004-03-11 15:26:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	114961

Description Andrew Farris 2004-03-11 05:06:46 UTC

Description of problem:
While system-config-samba displays the "Samba Users" dialog, clicking 
the "Edit Users" results in the Traceback below without opening the 
expected dialog.
----------------
Traceback (most recent call last):
  File "/usr/share/system-config-samba/sambaUserWin.py", line 144, in 
onEditUserButtonClicked
    user_dict = self.samba_user_data.getUserDict()
  File "/usr/share/system-config-samba/sambaUserData.py", line 86, in 
getUserDict
    if tmp_line[0] != '#':
IndexError: string index out of range
----------------

The "Delete User" button displays this similar Traceback, but appears 
to correctly remove the user from the dialog listbox.
----------------
Traceback (most recent call last):
  File "/usr/share/system-config-samba/sambaUserWin.py", line 164, in 
onDeleteUserButtonClicked
    self.samba_user_data.deleteUser(name, line)
  File "/usr/share/system-config-samba/sambaUserData.py", line 178, 
in deleteUser
    user_dict = self.getUserDict()
  File "/usr/share/system-config-samba/sambaUserData.py", line 86, in 
getUserDict
    if tmp_line[0] != '#':
IndexError: string index out of range
----------------

Version-Release number of selected component (if applicable):
system-config-samba-1.2.5-1

Related:
python-2.3.3-2.1
pygtk2-2.0.0-5.1
libuser-0.51.7-7.1.1
htmlview-2.0.0-12
samba-3.0.2a-1.1
usermode-1.69-5

How reproducible:
always

Steps to Reproduce:
1. Run system-config-samba as root
2. Select menu "Preferences", option "Samba Users"
3. Select a local logon user
4. Click the "Edit User" button
  
Actual results:
Edit Users dialog fails to display, Traceback displayed

Expected results:
Edit Users dialog box displayed

Additional info:
Last rawhide update 03/10/04 14:29:14 PST
Samba users have been previously configured with both the command 
line tools and SWAT

Comment 1 Brent Fox 2004-03-11 15:26:47 UTC

This bug was caused due to blank lines in the smbusers file which was
not expected.  Should be fixed in system-config-samba-1.2.6-1 in
Rawhide.  Thanks for your report.