Bug 1183361

Summary:	Update python-fedmsg-meta-fedora-infrastructure Requires for python-dateutil
Product:	[Fedora] Fedora	Reporter:	Pete Travis <me>
Component:	python-fedmsg-meta-fedora-infrastructure	Assignee:	Ralph Bean <rbean>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ian, lmacken, rbean, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://lists.fedoraproject.org/pipermail/devel/2014-December/205006.html
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-02-18 17:16:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1126521

Description Pete Travis 2015-01-18 21:04:59 UTC

python-dateutil will be updated to version 2.x and there may be changes that affect this package.  

If python-fedmsg-meta-fedora-infrastructure will work with the newer python-dateutil, you can safely close this bug.  If python-fedmsg-meta-fedora-infrastructure really does require python-dateutil 1.5, please use Requires: python-dateutil15 for Fedora versions of the package until it can be updated.

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-01-30 17:28:48 UTC

Hm, this calls 

    now = datetime.datetime.utcnow()
    mdate = meeting['meeting_date']
    mtime = meeting['meeting_time_start']
    dt_string = "%s %s" % (mdate, mtime)
    meeting_dt = datetime.datetime.strptime(dt_string, "%Y-%m-%d %H:%M:%S")
    relative_td = dateutil.relativedelta.relativedelta(meeting_dt, now)

Should be fine, but hard to say for certain just by looking at the code.

Tests pass.

Comment 2 Ralph Bean 2015-02-18 17:16:22 UTC

The tests are authoritative on this one.  It's fine (I develop against dateutil-2.2).

Thanks!