Bug 1183361 - Update python-fedmsg-meta-fedora-infrastructure Requires for python-dateutil
Summary: Update python-fedmsg-meta-fedora-infrastructure Requires for python-dateutil
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: python-fedmsg-meta-fedora-infrastructure
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ralph Bean
QA Contact: Fedora Extras Quality Assurance
URL: https://lists.fedoraproject.org/piper...
Whiteboard:
Depends On:
Blocks: 1126521
TreeView+ depends on / blocked
 
Reported: 2015-01-18 21:04 UTC by Pete Travis
Modified: 2015-02-18 17:16 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-18 17:16:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Pete Travis 2015-01-18 21:04:59 UTC
python-dateutil will be updated to version 2.x and there may be changes that affect this package.  

If python-fedmsg-meta-fedora-infrastructure will work with the newer python-dateutil, you can safely close this bug.  If python-fedmsg-meta-fedora-infrastructure really does require python-dateutil 1.5, please use Requires: python-dateutil15 for Fedora versions of the package until it can be updated.

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-01-30 17:28:48 UTC
Hm, this calls 

    now = datetime.datetime.utcnow()
    mdate = meeting['meeting_date']
    mtime = meeting['meeting_time_start']
    dt_string = "%s %s" % (mdate, mtime)
    meeting_dt = datetime.datetime.strptime(dt_string, "%Y-%m-%d %H:%M:%S")
    relative_td = dateutil.relativedelta.relativedelta(meeting_dt, now)

Should be fine, but hard to say for certain just by looking at the code.

Tests pass.

Comment 2 Ralph Bean 2015-02-18 17:16:22 UTC
The tests are authoritative on this one.  It's fine (I develop against dateutil-2.2).

Thanks!


Note You need to log in before you can comment on or make changes to this bug.