Bug 1184920
| Summary: | Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | Package Review | Assignee: | Josef Stribny <jstribny> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hhorak, jstribny, package-review |
| Target Milestone: | --- | Flags: | jstribny:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-rails-dom-testing-1.0.5-1.fc22 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-01-26 15:16:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1184130 | ||
| Bug Blocks: | 1184910, 1184996 | ||
|
Description
Vít Ondruch
2015-01-22 13:09:06 UTC
I will take it for a review. * Extra space before a dot: "Dom and Selector assertions for Rails applications ." * Wrong upstream URL: https://github.com/rails/rails-dom-testing is the new official URL from which the latest release comes from. Upstream should probably fix that in .gemspec. Otherwise everything looks sane, package builds and runs, rpmlint does not complain about anything meaningful. ==> APPROVED. Please fix the above before pushing. (In reply to Josef Stribny from comment #2) > * Extra space before a dot: > > "Dom and Selector assertions for Rails applications ." I already fixed this locally. > * Wrong upstream URL: > > https://github.com/rails/rails-dom-testing is the new official URL from > which the latest release comes from. Upstream should probably fix that in > .gemspec. Hmm, not sure about this. I checked the former URL and the URL you are referencing and both are valid/the same ATM, where the one in .gemspec is fork of the one you are referencing. I prefer to keep the .gemspec one ATM and will see what will future bring. > Otherwise everything looks sane, package builds and runs, rpmlint does not > complain about anything meaningful. ==> APPROVED. Please fix the above > before pushing. Thanks for the review. New Package SCM Request ======================= Package Name: rubygem-rails-dom-testing Short Description: Compares doms and assert certain elements exists in doms using Nokogiri Upstream URL: https://github.com/kaspth/rails-dom-testing Owners: vondruch jstribny Branches: InitialCC: Git done (by process-git-requests). |