Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-rails-dom-testing.git/tree/rubygem-rails-dom-testing.spec?id=a5212605c312a77dd6dbbc4f014be5102b81c1c8 SRPM URL: http://people.redhat.com/vondruch/rubygem-rails-dom-testing-1.0.5-1.fc22.src.rpm Description: Dom and Selector assertions for Rails applications. Fedora Account System Username: vondruch
I will take it for a review.
* Extra space before a dot: "Dom and Selector assertions for Rails applications ." * Wrong upstream URL: https://github.com/rails/rails-dom-testing is the new official URL from which the latest release comes from. Upstream should probably fix that in .gemspec. Otherwise everything looks sane, package builds and runs, rpmlint does not complain about anything meaningful. ==> APPROVED. Please fix the above before pushing.
(In reply to Josef Stribny from comment #2) > * Extra space before a dot: > > "Dom and Selector assertions for Rails applications ." I already fixed this locally. > * Wrong upstream URL: > > https://github.com/rails/rails-dom-testing is the new official URL from > which the latest release comes from. Upstream should probably fix that in > .gemspec. Hmm, not sure about this. I checked the former URL and the URL you are referencing and both are valid/the same ATM, where the one in .gemspec is fork of the one you are referencing. I prefer to keep the .gemspec one ATM and will see what will future bring. > Otherwise everything looks sane, package builds and runs, rpmlint does not > complain about anything meaningful. ==> APPROVED. Please fix the above > before pushing. Thanks for the review. New Package SCM Request ======================= Package Name: rubygem-rails-dom-testing Short Description: Compares doms and assert certain elements exists in doms using Nokogiri Upstream URL: https://github.com/kaspth/rails-dom-testing Owners: vondruch jstribny Branches: InitialCC:
Git done (by process-git-requests).