Bug 1185565
| Summary: | output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Schwendt <bugs.michael> |
| Component: | fedora-review | Assignee: | Stanislav Ochotnicky <sochotni> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 21 | CC: | empateinfinito, fedora, fedora, ggillies, hobbes1069, leamas.alec, petersen, phracek, pingou, sochotni |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-04-15 13:47:37 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Hm... looks like a dup of bug #1085761. If so, it should be fixed in latest release. Can you re-check using that?? There's no newer release in Rawhide either, and the ticket you mention is a couple of months old. ??? Whether this is a dupe, I cannot tell. The stuff that's printed is different. On Fedora 21 I have installed fedora-review-0.5.2-2-fc21.noarch and in ~/.cache/fedora-review.log I see the same messages 02-12 10:28 root WARNING Illegal return from /usr/share/fedora-review/scripts/python-egg-info.sh, code 82, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier ./review-env.sh: line 7: unset: `BASH_FUNC_scl()': not a valid identifier ./review-env.sh: line 7: unset: `[': not a valid identifier ./review-env.sh: line 7: unset: `"$CMD"': not a valid identifier 02-12 10:28 root DEBUG python-egg-info completed: 0.009 seconds 02-12 10:28 root DEBUG Running check: python-meet-guidelines 02-12 10:28 root WARNING Illegal return from /usr/share/fedora-review/scripts/python-meet-guidelines.sh, code 82, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier ./review-env.sh: line 7: unset: `BASH_FUNC_scl()': not a valid identifier ./review-env.sh: line 7: unset: `[': not a valid identifier ./review-env.sh: line 7: unset: `"$CMD"': not a valid identifier 02-12 10:28 root DEBUG python-meet-guidelines completed: 0.008 seconds 02-12 10:28 root DEBUG Running check: python-dont-download-deps 02-12 10:28 root WARNING Illegal return from /usr/share/fedora-review/scripts/python-dont-download-deps.sh, code 82, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier ./review-env.sh: line 7: unset: `BASH_FUNC_scl()': not a valid identifier ./review-env.sh: line 7: unset: `[': not a valid identifier ./review-env.sh: line 7: unset: `"$CMD"': not a valid identifier 02-12 10:28 root DEBUG python-dont-download-deps completed: 0.008 seconds 02-12 10:28 root DEBUG Running check: php-compatinfo 02-12 10:28 root DEBUG php-compatinfo completed: 0.000 seconds 02-12 10:28 root DEBUG Running check: generic-large-data 02-12 10:28 root WARNING Illegal return from /usr/share/fedora-review/scripts/generic-large-data.sh, code 80, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier ./review-env.sh: line 7: unset: `BASH_FUNC_scl()': not a valid identifier ./review-env.sh: line 7: unset: `[': not a valid identifier ./review-env.sh: line 7: unset: `"$CMD"': not a valid identifier Same here. I think this may be caused by scl-utils - at least removing it (and rebooting) worked around it. Same issue :( Hi Jens, Thanks for the workaround. Issues with SCL are not longer available but I have discovered new issues. INFO: Starting new HTTPS connection (1): admin.fedoraproject.org WARNING: Illegal return from /usr/share/fedora-review/scripts/generic-large-docs.sh, code 82, output: stdout:Documentation size is 10240 bytes in 0 files. stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier INFO: ExclusiveArch dependency checking disabled, enable with EXARCH flag WARNING: Illegal return from /usr/share/fedora-review/scripts/generic-excludearch.sh, code 82, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier WARNING: Illegal return from /usr/share/fedora-review/scripts/generic-srv-opt.sh, code 80, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier WARNING: Illegal return from /usr/share/fedora-review/scripts/python-check-eggs.sh, code 80, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier WARNING: Illegal return from /usr/share/fedora-review/scripts/python-egg-info.sh, code 82, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier WARNING: Illegal return from /usr/share/fedora-review/scripts/python-meet-guidelines.sh, code 82, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier WARNING: Illegal return from /usr/share/fedora-review/scripts/python-dont-download-deps.sh, code 82, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier WARNING: Illegal return from /usr/share/fedora-review/scripts/generic-large-data.sh, code 83, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier Review template in: /home/phracek/work/programming/Copr/preupgrade-assistant/review-preupgrade-assistant/review.txt fedora-review is automated tool, but *YOU* are responsible for manually reviewing the results and finishing the review. Do not just copy-paste the results without understanding them. I think this is a fedora-review bug in the handling of shell env, but I also removed environment-modules. So I think the correct workaround might be to "dnf/yum remove environment-modules", until fedora-review gets fixed. I've added two bugs as 'see also' (the one that Alec mentioned in comment #1, and a more recent one). I think they're likely all the same issue, but I'll leave it up to maintainers to mark them as duplicates. Any progress on this? *** This bug has been marked as a duplicate of bug 1206648 *** |
fedora-review prints the following multiple times: WARNING: Illegal return from /usr/share/fedora-review/scripts/generic-excludearch.sh, code 82, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier ./review-env.sh: line 7: unset: `BASH_FUNC_scl()': not a valid identifier ./review-env.sh: line 7: unset: `[': not a valid identifier ./review-env.sh: line 7: unset: `"$CMD"': not a valid identifier Line 7 is: unset $(env | sed -n 's/=.*//p') $ env|grep BASH_FUNC BASH_FUNC_module()=() { eval `/usr/bin/modulecmd bash $*` BASH_FUNC_scl()=() { local CMD=$1; fedora-review-0.5.2-1.fc21.noarch