The fedora-review tool generates a script named "review-env.sh" that starts with the following: unset $(env | sed -n 's/=.*//p') This generates warnings when there are exported bash functions in the environment: $ env [...] BASH_FUNC_scl()=() { local CMD=$1; if [ "$CMD" = "load" -o "$CMD" = "unload" ]; then eval "module $@"; else /usr/bin/scl "$@"; fi } Which results in: WARNING: Illegal return from /usr/share/fedora-review/scripts/generic-excludearch.sh, code 82, output: stdout:None stderr:./review-env.sh: line 7: unset: `BASH_FUNC_module()': not a valid identifier ./review-env.sh: line 7: unset: `BASH_FUNC_scl()': not a valid identifier ./review-env.sh: line 7: unset: `[': not a valid identifier ./review-env.sh: line 7: unset: `"$CMD"': not a valid identifier If this script wants to start with a clean environment, it should consider something like: #!/bin/sh if ! [ "$CLEAN_ENVIRONMENT=1" ]; then exec env -i CLEAN_ENVIRONMENT=1 $0 fi Or just filtering out bash functions: unset $(env | grep '^[[:alpha:]]' | grep -v '()=()' | sed -n 's/=.*//p')
Fixed in upstream commits: https://fedorahosted.org/FedoraReview/changeset/8d69b0f8216a99c66d7d77 https://fedorahosted.org/FedoraReview/changeset/c5af12e9aacb007f2c2323
*** Bug 1185565 has been marked as a duplicate of this bug. ***
(In reply to Alec Leamas from comment #2) > Fixed in upstream commits: > > https://fedorahosted.org/FedoraReview/changeset/8d69b0f8216a99c66d7d77 > https://fedorahosted.org/FedoraReview/changeset/c5af12e9aacb007f2c2323 Just for the record, I think this was fixed in commits: https://fedorahosted.org/FedoraReview/changeset/c6c5540c50cf4f0d87c7a544d8c7a3cbb3523da2 https://fedorahosted.org/FedoraReview/changeset/18d98aa3d0f441f7cd4732d7079dcaef06eab934