Bug 1185963 (kde-gtk-config)
| Summary: | Review Request: kde-gtk-config - Configure the appearance of GTK apps in KDE | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dvratil, jeischma, package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-05-23 14:39:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1135103 | ||
|
Description
Daniel Vrátil
2015-01-26 17:22:16 UTC
naming: ok
licensing: not ok
1. MUST use:
# KDE e.V. may determine that future GPL versions are accepted
License: GPLv2 or GPLv3
I'm only referencing aggregate GPL here, there is a mixture of both, so if you prefer, you can also do:
# KDE e.V. may determine that future GPL versions are accepted
# KDE e.V. may determine that future LGPL versions are accepted
License: (GPLv2 or GPLv3) and (LGPLv2 or LGPLv3)
sources: ok
283896b01e1d0a2bacf45498aeffefae kde-gtk-config-5.2.0.tar.xz
scriptlets: ok
macros: ok
2. SHOULD omit these bits:
# not *required*, but very nice. allows support for instant changes, gtk3.
Requires: xsettings-kde
Obsoletes: kcm-gtk < 5
Provides: kcm-gtk = %{version}-%{release}
until the interaction is better understood (ie, I don't think this one uses xsettings at all, and per irc conversation, we could keep the option open to keeping kcm-gtk alive)
Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kde-gtk-config.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kde-gtk-config-5.2.0-2.fc21.src.rpm * Tue Jan 27 2015 Daniel Vrátil <dvratil> - 5.2.0-2 - fix license - remove Obsoletes/Provides kcm-gtk - remove Requires xsettings-kde *** Bug 1174848 has been marked as a duplicate of this bug. *** Looks good thanks, APPROVED New Package SCM Request ======================= Package Name: kde-gtk-config Short Description: Configure the appearance of GTK apps in KDE Upstream URL: https://projects.kde.org/projects/kde/workspace/kde-gtk-config Owners: rdieter group::kde-sig Branches: f22 Git done (by process-git-requests). imported kde-gtk-config-5.3.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/kde-gtk-config-5.3.0-1.fc22 kde-gtk-config-5.3.0-1.fc22 has been pushed to the Fedora 22 testing repository. |